| Message ID | 20181125205000.10324-26-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | MAINTAINERS: Add various missing entries | expand |
On 2018-11-25 21:50, Philippe Mathieu-Daudé wrote: > The list is always selected by the 'All patches CC here' section. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > MAINTAINERS | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index c616861ca3..9d6dae71ff 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -109,7 +109,6 @@ L: qemu-s390x@nongnu.org > Guest CPU cores (TCG): > ---------------------- > Overall > -L: qemu-devel@nongnu.org > M: Peter Crosthwaite <crosthwaite.peter@gmail.com> > M: Richard Henderson <rth@twiddle.net> > R: Paolo Bonzini <pbonzini@redhat.com> > @@ -403,30 +402,25 @@ Hosts: > ------ > > LINUX > -L: qemu-devel@nongnu.org > S: Maintained > F: linux-* > F: linux-headers/ > > POSIX > -L: qemu-devel@nongnu.org > S: Maintained > F: *posix* I agree that we can remove the "L: qemu-devel" entries everywhere, but for these subsystems that have no "M:" entry, but "S: Maintained", this now looks somewhat strange - the subsystem is "Maintained" but has no maintainer? I think we need somebody who feels responsible to pick up patches here...? Thomas
Thomas Huth <thuth@redhat.com> writes: > On 2018-11-25 21:50, Philippe Mathieu-Daudé wrote: >> The list is always selected by the 'All patches CC here' section. >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> --- >> MAINTAINERS | 13 ------------- >> 1 file changed, 13 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index c616861ca3..9d6dae71ff 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -109,7 +109,6 @@ L: qemu-s390x@nongnu.org >> Guest CPU cores (TCG): >> ---------------------- >> Overall >> -L: qemu-devel@nongnu.org >> M: Peter Crosthwaite <crosthwaite.peter@gmail.com> >> M: Richard Henderson <rth@twiddle.net> >> R: Paolo Bonzini <pbonzini@redhat.com> >> @@ -403,30 +402,25 @@ Hosts: >> ------ >> >> LINUX >> -L: qemu-devel@nongnu.org >> S: Maintained >> F: linux-* >> F: linux-headers/ >> >> POSIX >> -L: qemu-devel@nongnu.org >> S: Maintained >> F: *posix* > > I agree that we can remove the "L: qemu-devel" entries everywhere, but > for these subsystems that have no "M:" entry, but "S: Maintained", this > now looks somewhat strange - the subsystem is "Maintained" but has no > maintainer? I think we need somebody who feels responsible to pick up > patches here...? It looks strange because it *is* strange. If we take the definition of S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, not a mailing list), or downgrade to S: Orphan.
On 27/11/18 09:59, Markus Armbruster wrote: >>> LINUX >>> -L: qemu-devel@nongnu.org >>> S: Maintained >>> F: linux-* This pattern only matches ./block/linux-aio.c ./stubs/linux-aio.c so it can be removed >>> F: linux-headers/ For this I propose mst, Conny and myself. >>> POSIX >>> -L: qemu-devel@nongnu.org >>> S: Maintained >>> F: *posix* >> >> I agree that we can remove the "L: qemu-devel" entries everywhere, but >> for these subsystems that have no "M:" entry, but "S: Maintained", this >> now looks somewhat strange - the subsystem is "Maintained" but has no >> maintainer? I think we need somebody who feels responsible to pick up >> patches here...? > > It looks strange because it *is* strange. If we take the definition of > S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, > not a mailing list), or downgrade to S: Orphan. I can volunteer for this one too, but please change the F: patterns to F: os-posix.c F: include/sysemu/os-posix.h F: util/*posix*.c F: include/qemu/*posix*.h Thanks, Paolo
On 27/11/18 10:18, Paolo Bonzini wrote: > On 27/11/18 09:59, Markus Armbruster wrote: >>>> LINUX >>>> -L: qemu-devel@nongnu.org >>>> S: Maintained >>>> F: linux-* > > This pattern only matches > > ./block/linux-aio.c > ./stubs/linux-aio.c > > so it can be removed > OK >>>> F: linux-headers/ > > For this I propose mst, Conny and myself. Or remove... I'll let them opinate. > >>>> POSIX >>>> -L: qemu-devel@nongnu.org >>>> S: Maintained >>>> F: *posix* >>> >>> I agree that we can remove the "L: qemu-devel" entries everywhere, but >>> for these subsystems that have no "M:" entry, but "S: Maintained", this >>> now looks somewhat strange - the subsystem is "Maintained" but has no >>> maintainer? I think we need somebody who feels responsible to pick up >>> patches here...? >> >> It looks strange because it *is* strange. If we take the definition of >> S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, >> not a mailing list), or downgrade to S: Orphan. > > I can volunteer for this one too, but please change the F: patterns to > > F: os-posix.c > F: include/sysemu/os-posix.h > F: util/*posix*.c > F: include/qemu/*posix*.h OK, will do. Thanks Paolo, Phil. > > Thanks, > > Paolo >
On Tue, 27 Nov 2018 10:18:04 +0100 Paolo Bonzini <pbonzini@redhat.com> wrote: > On 27/11/18 09:59, Markus Armbruster wrote: > >>> F: linux-headers/ > > For this I propose mst, Conny and myself. Fine with me.
diff --git a/MAINTAINERS b/MAINTAINERS index c616861ca3..9d6dae71ff 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -109,7 +109,6 @@ L: qemu-s390x@nongnu.org Guest CPU cores (TCG): ---------------------- Overall -L: qemu-devel@nongnu.org M: Peter Crosthwaite <crosthwaite.peter@gmail.com> M: Richard Henderson <rth@twiddle.net> R: Paolo Bonzini <pbonzini@redhat.com> @@ -403,30 +402,25 @@ Hosts: ------ LINUX -L: qemu-devel@nongnu.org S: Maintained F: linux-* F: linux-headers/ POSIX -L: qemu-devel@nongnu.org S: Maintained F: *posix* NETBSD -L: qemu-devel@nongnu.org M: Kamil Rytarowski <kamil@netbsd.org> S: Maintained K: ^Subject:.*(?i)NetBSD OPENBSD -L: qemu-devel@nongnu.org M: Brad Smith <brad@comstyle.com> S: Maintained K: ^Subject:.*(?i)OpenBSD W32, W64 -L: qemu-devel@nongnu.org M: Stefan Weil <sw@weilnetz.de> S: Maintained F: *win32* @@ -532,7 +526,6 @@ F: include/hw/*/digic* Gumstix M: Peter Maydell <peter.maydell@linaro.org> R: Philippe Mathieu-Daudé <f4bug@amsat.org> -L: qemu-devel@nongnu.org L: qemu-arm@nongnu.org S: Odd Fixes F: hw/arm/gumstix.c @@ -953,7 +946,6 @@ F: include/hw/intc/heathrow_pic.h PReP M: Hervé Poussineau <hpoussin@reactos.org> -L: qemu-devel@nongnu.org L: qemu-ppc@nongnu.org S: Maintained F: hw/ppc/prep.c @@ -1690,7 +1682,6 @@ S: Supported F: scripts/coverity-model.c CPU -L: qemu-devel@nongnu.org S: Supported F: qom/cpu.c F: include/qom/cpu.h @@ -1722,7 +1713,6 @@ F: util/error.c F: util/qemu-error.c GDB stub -L: qemu-devel@nongnu.org S: Odd Fixes F: gdbstub* F: gdb-xml/ @@ -2124,7 +2114,6 @@ F: tcg/arm/ F: disas/arm.c i386 target -L: qemu-devel@nongnu.org S: Maintained F: tcg/i386/ F: disas/i386.c @@ -2389,7 +2378,6 @@ Build and test automation M: Alex Bennée <alex.bennee@linaro.org> M: Fam Zheng <famz@redhat.com> R: Philippe Mathieu-Daudé <philmd@redhat.com> -L: qemu-devel@nongnu.org S: Maintained F: .travis.yml F: scripts/travis/ @@ -2405,7 +2393,6 @@ M: Alex Bennée <alex.bennee@linaro.org> R: Philippe Mathieu-Daudé <f4bug@amsat.org> F: tests/tcg/Makefile F: tests/tcg/Makefile.include -L: qemu-devel@nongnu.org Documentation -------------
The list is always selected by the 'All patches CC here' section. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- MAINTAINERS | 13 ------------- 1 file changed, 13 deletions(-)