| Message ID | 20181011171254.32428-1-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | vl: Print error when using incorrect backend for debugcon | expand |
On Thu, Oct 11, 2018 at 9:13 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > When using an incorrect backend for the debugcon, QEMU exits silently > without any error indication, which is confusing. > Add a message that the character backend is invalid. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > vl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/vl.c b/vl.c > index 4e25c78bff..61305b5891 100644 > --- a/vl.c > +++ b/vl.c > @@ -2466,6 +2466,7 @@ static int debugcon_parse(const char *devname) > QemuOpts *opts; > > if (!qemu_chr_new_mux_mon("debugcon", devname)) { > + error_report("invalid character backend '%s'", devname); > exit(1); > } > opts = qemu_opts_create(qemu_find_opts("device"), "debugcon", 1, NULL); > -- > 2.17.1 >
Cc'ing qemu-trivial@ On 11/10/2018 23:48, Marc-André Lureau wrote: > On Thu, Oct 11, 2018 at 9:13 PM Philippe Mathieu-Daudé > <philmd@redhat.com> wrote: >> >> When using an incorrect backend for the debugcon, QEMU exits silently >> without any error indication, which is confusing. >> Add a message that the character backend is invalid. >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > >> --- >> vl.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/vl.c b/vl.c >> index 4e25c78bff..61305b5891 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -2466,6 +2466,7 @@ static int debugcon_parse(const char *devname) >> QemuOpts *opts; >> >> if (!qemu_chr_new_mux_mon("debugcon", devname)) { >> + error_report("invalid character backend '%s'", devname); >> exit(1); >> } >> opts = qemu_opts_create(qemu_find_opts("device"), "debugcon", 1, NULL); >> -- >> 2.17.1 >>
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > When using an incorrect backend for the debugcon, QEMU exits silently > without any error indication, which is confusing. > Add a message that the character backend is invalid. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Queued, thanks!
diff --git a/vl.c b/vl.c index 4e25c78bff..61305b5891 100644 --- a/vl.c +++ b/vl.c @@ -2466,6 +2466,7 @@ static int debugcon_parse(const char *devname) QemuOpts *opts; if (!qemu_chr_new_mux_mon("debugcon", devname)) { + error_report("invalid character backend '%s'", devname); exit(1); } opts = qemu_opts_create(qemu_find_opts("device"), "debugcon", 1, NULL);
When using an incorrect backend for the debugcon, QEMU exits silently without any error indication, which is confusing. Add a message that the character backend is invalid. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- vl.c | 1 + 1 file changed, 1 insertion(+)