From patchwork Wed May 16 18:51:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Edgar E. Iglesias" X-Patchwork-Id: 914858 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YH+qfwgx"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40mNtT29ppz9s1B for ; Thu, 17 May 2018 04:55:45 +1000 (AEST) Received: from localhost ([::1]:34120 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJ1aQ-0005SN-Nv for incoming@patchwork.ozlabs.org; Wed, 16 May 2018 14:55:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJ1Wm-0002s5-4i for qemu-devel@nongnu.org; Wed, 16 May 2018 14:51:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJ1Wh-0000f9-NF for qemu-devel@nongnu.org; Wed, 16 May 2018 14:51:56 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:38488) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fJ1Wh-0000eu-Gh for qemu-devel@nongnu.org; Wed, 16 May 2018 14:51:51 -0400 Received: by mail-wm0-x243.google.com with SMTP id m129-v6so4228526wmb.3 for ; Wed, 16 May 2018 11:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZuqoeEh2iRHdYcrhRznRZMZfGgaIogY6PwFPOwEPfM8=; b=YH+qfwgxD5pbpoqo+3LaG3G5DFE0T15z7UODIArHKjnfHMFdXzTbBAjdex2TIL8jFi c/ZZZYokxbpmHrTjRAG0sW6r9HgupW9eR0+a5nTkdP7P89PB5SmWPT/Ee5EDzJmRfASH zRkshojIgRSpR+ZGG6JcDdrHaoJevQS9HM1yNY8R2FGoIj8PZYewz+afNp8EnsHoShLP CxH8qoETqDWHM3U6lyz9dbBICB8rBX1NcL9WcK9JZHF5TCZProCeMQs2Y1liHkK0pmUE TcZ2XugLSnZ8lAH2ghhsG8lxUwHU29+jWb0Dj+wVAnOfevWPc0Sp/N2nURfeFI9aoxFf DPbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZuqoeEh2iRHdYcrhRznRZMZfGgaIogY6PwFPOwEPfM8=; b=AbsI5wPhW2BHyW5l4GpJBsylJRwPUgq+RihNyLK/ZlvTgM/PpsqQdwITo+eiaZWW5p wU7p1s5tV6MNbE1uTt/dhJYLst/7bCTDojxI+qPGF78dwKCNwLGdaTrfp6h434DQvYa1 jJa8EdpWYmtIu3oFsNy4nb4KrBICaXplaMjMVot6hmWstn9OgWqL1Az+egYlqW0409d/ V7jOy985lxDH0d2mou5U/PxMDKdM0oaoXDee89PrGYZLP5uJvHOXJSQ0tWB03FdtZneJ YFhE7/N/VvXWO/n2ydW0HmFVa3VaWShVXb9nmf468mcD2eF9wXuvUZiu23T5+YVwKmKq xexA== X-Gm-Message-State: ALKqPwfg1WeUsMHFFp8nIKFheW0mdOPNPMzgb6UhHdiHvy8vVsQXWUnT ZyRFQGNSNa7f25fh3rnBfvpnjw== X-Google-Smtp-Source: AB8JxZqkGGVkZYKQ6L/vrTvd+qCi+5IVDlbJ61ugzG/R6xW2vgT9SNOCE59ovxwIt2y5vW3AEnfSjg== X-Received: by 2002:a2e:3806:: with SMTP id f6-v6mr1302930lja.25.1526496710042; Wed, 16 May 2018 11:51:50 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id x26-v6sm504653ljd.81.2018.05.16.11.51.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 May 2018 11:51:49 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Wed, 16 May 2018 20:51:09 +0200 Message-Id: <20180516185146.30708-2-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180516185146.30708-1-edgar.iglesias@gmail.com> References: <20180516185146.30708-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PATCH v3 01/38] target-microblaze: dec_load: Use bool instead of unsigned int X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sstabellini@kernel.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org, frederic.konrad@adacore.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: "Edgar E. Iglesias" Use bool instead of unsigned int to represent flags. No functional change. Reviewed-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 0872dc9ded..a8a5eaebec 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -897,14 +897,15 @@ static inline TCGv *compute_ldst_addr(DisasContext *dc, TCGv *t) static void dec_load(DisasContext *dc) { TCGv t, v, *addr; - unsigned int size, rev = 0, ex = 0; + unsigned int size; + bool rev = false, ex = false; TCGMemOp mop; mop = dc->opcode & 3; size = 1 << mop; if (!dc->type_b) { - rev = (dc->ir >> 9) & 1; - ex = (dc->ir >> 10) & 1; + rev = extract32(dc->ir, 9, 1); + ex = extract32(dc->ir, 10, 1); } mop |= MO_TE; if (rev) {