From patchwork Thu May 3 18:21:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 908150 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=208.118.235.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="rHmUAmGS"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40cNmF4lyZz9s02 for ; Fri, 4 May 2018 04:22:37 +1000 (AEST) Received: from localhost ([::1]:58172 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEIsF-000373-HU for incoming@patchwork.ozlabs.org; Thu, 03 May 2018 14:22:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEIqX-00023e-3B for qemu-devel@nongnu.org; Thu, 03 May 2018 14:20:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEIqU-0008GU-JF for qemu-devel@nongnu.org; Thu, 03 May 2018 14:20:49 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:34972) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEIqU-0008GC-CT for qemu-devel@nongnu.org; Thu, 03 May 2018 14:20:46 -0400 Received: by mail-wm0-x241.google.com with SMTP id o78-v6so511859wmg.0 for ; Thu, 03 May 2018 11:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3wARq2JHuhrPn5F8+/vs2t7XR95j87CYGPhla7MpRMs=; b=rHmUAmGS2xAcS/BGgf1QyXnB6nmn1HTN2lBn/RHwBRs0GFnBV2QCuhJhidALRHYgaZ S191LcWHCP53FbgfZGQXDI+WuoQvR82PrVIMl7C+Ybo7GF82PWq317X5cC2npyTc3c4u jT/OOOKFavLavLxFIfiu77bZL87SVQLq/75/Vf+HCuw/fOuNogsIMXueGEl4FTbGsiVT YStpE9ugR/W0JY84K2FdeKjBeiu7U2CanW1Q4tizbmCX9xy0qWDTKboofU4TgLAGV3jQ Cc28BjRQtYZ04n1SZeRtMW5OJ2umGkZ6nbzg/zIZbquc3O8ZNKHaPww8GH8lp412zN8a SKXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3wARq2JHuhrPn5F8+/vs2t7XR95j87CYGPhla7MpRMs=; b=DfZBTBxjfintfY/nX3zHFXpbNOWRBLdmDItRWZdIvjKtP6ZZrPBFZoxkY4Pv43wMhr L1gm9lOMO0PoDz0eEPysL6X35PPkhynFfcp4AZSLca7QpW+HhmMbfkaARkNm43myFawt noJewKgQmwDog7kNML9Z7M29VKcQuQQJpU5mIiQRfc7Cbug7GRljaX6j6XBB5QpWWQrq fRYLB8dtlD5Nv1GwlLEqLwYzUlEhvFpuQY10aqJSrpNty8WtyLcLVRF5T7PEorz/SpGp D6eu9GDSMGbZLkbH2Rdlwy0V+vvYdQDqvR8pzfhUaUY38kcZAaGzuF9l3r8Nc6oL6A7l leWw== X-Gm-Message-State: ALQs6tAYx41m1fWFt+KL7yuTkDQ1eFZeFSjnw+N/igp9NnD85HoCGawU xrzM1QMwdw4PsgLZ5S3EwYPuLg== X-Google-Smtp-Source: AB8JxZq0t9NwNsZbsaAJyU7EoIV8hfaJ1noCFZKWv9L1sAzDD4snhV6GGdGHJ4I240Yzjje4LwYpoQ== X-Received: by 10.28.212.210 with SMTP id l201mr14674933wmg.98.1525371645105; Thu, 03 May 2018 11:20:45 -0700 (PDT) Received: from localhost.localdomain ([176.228.154.53]) by smtp.gmail.com with ESMTPSA id w40-v6sm24388801wrc.69.2018.05.03.11.20.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 May 2018 11:20:44 -0700 (PDT) From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Thu, 3 May 2018 21:21:18 +0300 Message-Id: <20180503182125.20310-2-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180503182125.20310-1-marcel.apfelbaum@gmail.com> References: <20180503182125.20310-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PULL 1/8] hw/rdma: Fix possible munmap call on a NULL pointer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, yuval.shaia@oracle.com, f4bug@amsat.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Coverity CID 1390620: we call munmap() on a NULL pointer. Reported-by: Peter Maydell Signed-off-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia Message-Id: <20180430200223.4119-2-marcel.apfelbaum@gmail.com> --- hw/rdma/vmw/pvrdma_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index 99019d8741..f9dd78cb27 100644 --- a/hw/rdma/vmw/pvrdma_cmd.c +++ b/hw/rdma/vmw/pvrdma_cmd.c @@ -232,7 +232,7 @@ static int create_mr(PVRDMADev *dev, union pvrdma_cmd_req *req, cmd->start, cmd->length, host_virt, cmd->access_flags, &resp->mr_handle, &resp->lkey, &resp->rkey); - if (!resp->hdr.err) { + if (host_virt && !resp->hdr.err) { munmap(host_virt, cmd->length); }