From patchwork Mon Apr 30 20:02:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 906846 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=208.118.235.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QuYb9PJQ"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40Zb7P1nNDz9s3F for ; Tue, 1 May 2018 06:02:51 +1000 (AEST) Received: from localhost ([::1]:33153 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDF0Y-0003kK-Km for incoming@patchwork.ozlabs.org; Mon, 30 Apr 2018 16:02:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDEzm-0003jZ-8H for qemu-devel@nongnu.org; Mon, 30 Apr 2018 16:01:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDEzk-0005qU-BK for qemu-devel@nongnu.org; Mon, 30 Apr 2018 16:01:58 -0400 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:42873) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDEzk-0005q5-4l for qemu-devel@nongnu.org; Mon, 30 Apr 2018 16:01:56 -0400 Received: by mail-wr0-x243.google.com with SMTP id v5-v6so9131386wrf.9 for ; Mon, 30 Apr 2018 13:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Na7tt5ypP3vhdS/FSS9QkxMmKJOy9mgzaiPHp6SkSQM=; b=QuYb9PJQHnkezESxQcgqKuIQXxi6kWSgeakaL6iXVasZHil59EcHDfKyoyOIJ3I2Ip 5QmvOvfmssc+FXty/OguA0VavmiQ0nM9EXUIO3GZwtjKj43PyVYjkzjlooH2WbBL70YS p1PgH2xyuWeqVMDS/61NBcHtpz3Wz/ePF3CjG6RpKFnkTs55zIP2LRS/JDdvr4JKrQUj TXhzCO7Q1zDtQ6gR/pDq8dfg1+gVAsy8214ov+AynFRAOAvNI9rfFUK3nRNQXuzxKElB dVV1xh3uojFS8gdX/Q63THKpZNt1VPTafJBKdYMObNN6rLdIz0KYz9cJMylUJG/oXewy CoGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Na7tt5ypP3vhdS/FSS9QkxMmKJOy9mgzaiPHp6SkSQM=; b=fIr/j9ME7NCDxMz7Tun0bNYhFPPS8eG9HVVeZF0kM969Xuv+L1kx++AiulVXk7fgfl 9m6tTyhg+9M13y1mgKzTR1AIsCD0KOoaqX7tgytrvA+ndymD8ircQiAe/pHZ18IF37/q 66r0oDmTE1mh84klBa7FLSU9k3LiXd622QKrq52MUHWgs4uOBC+uoPHJGZ7Gr3YPCRhi w72o4BTareKNiF/zg8OkAUVUx6gu98LMv6NXzwA8miPy1J69D3MEwH0BSLbxBAl2unuo ZA9L/NiiIXKw7WSwn1m9/SAAKdHvO4v0oflLg8N+v5G5WAuULIOmHpfsWr7+p+Q8JHqf Ieeg== X-Gm-Message-State: ALQs6tCnIcrp/I/Cwh4MOFeAzPYmjI4aXY2fPL8yOUhr/RwnzS9bwHiZ 9JpCu4BD2bMkQfs0OnRwyoQteQ== X-Google-Smtp-Source: AB8JxZq1RHr1bHowsGzVu1TI2UafqQzt9qpT93rMpDYUCaVazf/dDGFVCm4iGKXhmwIpJIT7tHwTSw== X-Received: by 2002:adf:d10f:: with SMTP id a15-v6mr10330837wri.165.1525118514701; Mon, 30 Apr 2018 13:01:54 -0700 (PDT) Received: from localhost.localdomain ([176.228.154.53]) by smtp.gmail.com with ESMTPSA id u35-v6sm8455997wrc.29.2018.04.30.13.01.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Apr 2018 13:01:54 -0700 (PDT) From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Mon, 30 Apr 2018 23:02:17 +0300 Message-Id: <20180430200223.4119-2-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180430200223.4119-1-marcel.apfelbaum@gmail.com> References: <20180430200223.4119-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::243 Subject: [Qemu-devel] [PATCH 1/7] hw/rdma: Fix possible munmap call on a NULL pointer X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, yuval.shaia@oracle.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Coverity CID 1390620: we call munmap() on a NULL pointer. Reported-by: Peter Maydell Signed-off-by: Marcel Apfelbaum Reviewed-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index 99019d8741..f9dd78cb27 100644 --- a/hw/rdma/vmw/pvrdma_cmd.c +++ b/hw/rdma/vmw/pvrdma_cmd.c @@ -232,7 +232,7 @@ static int create_mr(PVRDMADev *dev, union pvrdma_cmd_req *req, cmd->start, cmd->length, host_virt, cmd->access_flags, &resp->mr_handle, &resp->lkey, &resp->rkey); - if (!resp->hdr.err) { + if (host_virt && !resp->hdr.err) { munmap(host_virt, cmd->length); }