From patchwork Fri May 24 14:33:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Edgar E. Iglesias" X-Patchwork-Id: 246184 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EE88F2C008A for ; Sat, 25 May 2013 00:41:22 +1000 (EST) Received: from localhost ([::1]:42598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UftBI-0003tp-8a for incoming@patchwork.ozlabs.org; Fri, 24 May 2013 10:41:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UftAn-0003nv-DJ for qemu-devel@nongnu.org; Fri, 24 May 2013 10:40:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UftAh-0006D2-AZ for qemu-devel@nongnu.org; Fri, 24 May 2013 10:40:49 -0400 Received: from mail-ea0-x22a.google.com ([2a00:1450:4013:c01::22a]:56640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UftAg-0006Cc-To for qemu-devel@nongnu.org; Fri, 24 May 2013 10:40:43 -0400 Received: by mail-ea0-f170.google.com with SMTP id f15so2727982eak.29 for ; Fri, 24 May 2013 07:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=hLMZknBnZ1ZUUOaZHjudeYWf5iHZtrDKL54DaIHgMJE=; b=XhhNckiV5+19Q6xwjK3JmglrOw373pEl8nv8BTvhScDK0h+oIoJKp51WEoGlYrJ/a9 s7pa/gfUSR4jJsu3kI6jZMGR4nwNNZLqVdTfyDqTLAUnyH2fp8dEMj636njV21ksVWcn 2sT+Qz9yFiVC7Jgj0G2T2YnNJ4L13pzcb5sELhwXfjoFPfoUai93rjbvI6IeRgtVE34f SRbMzUFgB4nd8kerDNCTFI21/Im3ZO4dgmTzrPtp/wAr1PsHX/o/oTcBraP51pxBmSOk t4CG0fltsp8oV71b0ani4WS8KTwfA5LpGHPpOkp3MgUFo5WigBXzocEJWCQKVXylSuA3 crvg== X-Received: by 10.14.182.5 with SMTP id n5mr73213eem.151.1369405988265; Fri, 24 May 2013 07:33:08 -0700 (PDT) Received: from localhost (h59ec325f.selukar.dyn.perspektivbredband.net. [89.236.50.95]) by mx.google.com with ESMTPSA id y2sm24042475eeu.2.2013.05.24.07.33.04 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 24 May 2013 07:33:06 -0700 (PDT) Date: Fri, 24 May 2013 16:33:03 +0200 From: "Edgar E. Iglesias" To: Peter Maydell Message-ID: <20130524143303.GD23342@smtp.vpn> References: <5173E697.4050606@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::22a Cc: Blue Swirl , Paolo Bonzini , Peter Crosthwaite , qemu-devel Subject: Re: [Qemu-devel] [PATCH v5 3/3] configure/Make: Build libfdt from submodule DTC X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Fri, May 24, 2013 at 03:16:00PM +0100, Peter Maydell wrote: > On 22 April 2013 05:45, Peter Crosthwaite wrote: > > On Sun, Apr 21, 2013 at 11:16 PM, Paolo Bonzini wrote: > >> libfdt is not that portable, it doesn't use libtool to build shared > >> libraries. > >> > >> Perhaps we can just build the static library? > >> > > > > Seems reasonable, and got this working with fairly low effort. > > Fix on list. > > Hi -- can you point me at the fix? Did it get committed? > I did a search of my mail archives but couldn't find anything > that looked like it. > > (I'm looking at making libfdt mandatory for softmmu targets, for > which purpose we need to make sure all the libfdt build hiccups > are fixed...) Hi Peter, I think it was this one: Cheers, Edgar commit 9005a51b096272e1834638f8e184706548ee7364 Author: Peter Crosthwaite Date: Mon Apr 22 14:40:49 2013 +1000 Makefile: Don't build shared libfdt The submodule DTC should just build and use DTC as static (the whole motivation for using submod is lack of widespread distro support). The .so causes build failures on some platforms, so adjust the make target to just build the static lib. Signed-off-by: Peter Crosthwaite Signed-off-by: Edgar E. Iglesias diff --git a/Makefile b/Makefile index efb1c44..5140c19 100644 --- a/Makefile +++ b/Makefile @@ -149,7 +149,7 @@ DTC_MAKE_ARGS=-I$(SRC_PATH)/dtc VPATH=$(SRC_PATH)/dtc -C dtc DTC_CFLAGS=$(CFLAGS) $(extra_cflags) -I$(BUILD_DIR)/dtc -I$(SRC_PATH)/dtc -I$(S subdir-dtc:dtc/libfdt dtc/tests - $(call quiet-command,$(MAKE) $(DTC_MAKE_ARGS) CPPFLAGS="$(DTC_CFLAGS)" L + $(call quiet-command,$(MAKE) $(DTC_MAKE_ARGS) CPPFLAGS="$(DTC_CFLAGS)" L dtc/%: mkdir -p $@