From patchwork Tue Jun 28 19:02:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Edgar E. Iglesias" X-Patchwork-Id: 102446 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id ED4D9B6F59 for ; Wed, 29 Jun 2011 05:05:09 +1000 (EST) Received: from localhost ([::1]:40512 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qbdaq-0003Dp-Ng for incoming@patchwork.ozlabs.org; Tue, 28 Jun 2011 15:05:05 -0400 Received: from eggs.gnu.org ([140.186.70.92]:48021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbdYB-0003DB-0E for qemu-devel@nongnu.org; Tue, 28 Jun 2011 15:02:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbdY9-0000Dj-9l for qemu-devel@nongnu.org; Tue, 28 Jun 2011 15:02:18 -0400 Received: from mail-fx0-f47.google.com ([209.85.161.47]:63653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbdY8-0000Da-PF for qemu-devel@nongnu.org; Tue, 28 Jun 2011 15:02:17 -0400 Received: by fxg11 with SMTP id 11so556372fxg.34 for ; Tue, 28 Jun 2011 12:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=OnOAl0W+JwCJci92nZixwdIA7db9qwnrMhRqo5GD9A4=; b=WMqajG2laT65dxhqoIVbE55QaAmdvi54Y1h8hnfku5islJEWY9UdKsHPI2o66oKmLD MAhZQHQ1B5zQ086u31R/jJfVegpIdEvOT1BHV67LF5HskA3qD/UyLOkapdjZNtjKsrqp BNFTVAMUloe/gUo3/VPxGbOsqmmoJJeA8NHu4= Received: by 10.223.92.146 with SMTP id r18mr11034132fam.135.1309287735379; Tue, 28 Jun 2011 12:02:15 -0700 (PDT) Received: from localhost (h59ec3266.selukar.dyn.perspektivbredband.net [89.236.50.102]) by mx.google.com with ESMTPS id h1sm311401fag.35.2011.06.28.12.02.13 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 28 Jun 2011 12:02:14 -0700 (PDT) Date: Tue, 28 Jun 2011 21:02:12 +0200 From: "Edgar E. Iglesias" To: Matthew Fernandez Message-ID: <20110628190212.GB30019@laped.lan> References: <4DEDE627.1070907@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.161.47 Cc: Kevin Wolf , Blue Swirl , Anthony Liguori , qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH] Command line support for altering the log file location X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Wed, Jun 08, 2011 at 12:32:40PM +1000, Matthew Fernandez wrote: > Add command line support for logging to a location other than /tmp/qemu.log. > > With logging enabled (command line option -d), the log is written to > the hard-coded path /tmp/qemu.log. This patch adds support for writing > the log to a different location by passing the -D option. > > Signed-off-by: Matthew Fernandez > ---- Hi, I've applied the following, only tested on linux-user. Cheers commit 1dfdcaa83f9ce34aded8bc0669e81753d94f1b7d Author: Edgar E. Iglesias Date: Tue Jun 28 20:57:09 2011 +0200 user: Fix -d debug logging for usermode emulation Signed-off-by: Edgar E. Iglesias diff --git a/bsd-user/main.c b/bsd-user/main.c index 5f790b2..6018a41 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -866,7 +866,7 @@ int main(int argc, char **argv) int mask; const CPULogItem *item; - mask = cpu_str_to_log_mask(r); + mask = cpu_str_to_log_mask(log_mask); if (!mask) { printf("Log items (comma separated):\n"); for (item = cpu_log_items; item->mask != 0; item++) { diff --git a/darwin-user/main.c b/darwin-user/main.c index a6dc859..35196a1 100644 --- a/darwin-user/main.c +++ b/darwin-user/main.c @@ -819,7 +819,7 @@ int main(int argc, char **argv) int mask; CPULogItem *item; - mask = cpu_str_to_log_mask(r); + mask = cpu_str_to_log_mask(log_mask); if (!mask) { printf("Log items (comma separated):\n"); for (item = cpu_log_items; item->mask != 0; item++) { diff --git a/linux-user/main.c b/linux-user/main.c index db5577b..289054b 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -3030,7 +3030,7 @@ int main(int argc, char **argv, char **envp) int mask; const CPULogItem *item; - mask = cpu_str_to_log_mask(r); + mask = cpu_str_to_log_mask(log_mask); if (!mask) { printf("Log items (comma separated):\n"); for (item = cpu_log_items; item->mask != 0; item++) {