From patchwork Wed Jan 27 19:47:17 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 43831 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 942F2B7B98 for ; Thu, 28 Jan 2010 06:54:35 +1100 (EST) Received: from localhost ([127.0.0.1]:35022 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NaDva-0002Y6-KQ for incoming@patchwork.ozlabs.org; Wed, 27 Jan 2010 14:51:50 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NaDuL-0002XY-VQ for qemu-devel@nongnu.org; Wed, 27 Jan 2010 14:50:33 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NaDuG-0002Wj-JP for qemu-devel@nongnu.org; Wed, 27 Jan 2010 14:50:33 -0500 Received: from [199.232.76.173] (port=36053 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NaDuG-0002Wg-GC for qemu-devel@nongnu.org; Wed, 27 Jan 2010 14:50:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20514) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NaDuF-0000R1-TH for qemu-devel@nongnu.org; Wed, 27 Jan 2010 14:50:28 -0500 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0RJoPBc024763 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Jan 2010 14:50:25 -0500 Received: from redhat.com (vpn2-8-235.ams2.redhat.com [10.36.8.235]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id o0RJoM7F007195; Wed, 27 Jan 2010 14:50:23 -0500 Date: Wed, 27 Jan 2010 21:47:17 +0200 From: "Michael S. Tsirkin" To: Anthony Liguori Subject: Re: [Qemu-devel] [PATCHv2-repost 1/3] qemu: memory notifiers Message-ID: <20100127194715.GA4338@redhat.com> References: <20100125142912.GB11154@redhat.com> <4B5F75BF.1050005@codemonkey.ws> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4B5F75BF.1050005@codemonkey.ws> User-Agent: Mutt/1.5.19 (2009-01-05) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: qemu-devel@nongnu.org, gleb@redhat.com, avi@redhat.com X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Tue, Jan 26, 2010 at 05:07:43PM -0600, Anthony Liguori wrote: > On 01/25/2010 08:29 AM, Michael S. Tsirkin wrote: >> This adds notifiers for phys memory changes: a set of callbacks that >> vhost can register and update kernel accordingly. Down the road, kvm >> code can be switched to use these as well, instead of calling kvm code >> directly from exec.c as is done now. >> >> Signed-off-by: Michael S. Tsirkin >> Acked-by: Avi Kivity >> > > This breaks the linux-user build (exec.o: cpu_notify_set_memory defined > but not used). > > Regards, > > Anthony Liguori Ugh, this will fix it. Want me to repost the series? diff --git a/exec.c b/exec.c index 63caca0..2e7434e 100644 --- a/exec.c +++ b/exec.c @@ -1623,6 +1623,7 @@ const CPULogItem cpu_log_items[] = { { 0, NULL, NULL }, }; +#ifndef CONFIG_USER_ONLY static QLIST_HEAD(memory_client_list, CPUPhysMemoryClient) memory_client_list = QLIST_HEAD_INITIALIZER(memory_client_list); @@ -1715,6 +1716,7 @@ void cpu_unregister_phys_memory_client(CPUPhysMemoryClient *client) { QLIST_REMOVE(client, list); } +#endif static int cmp1(const char *s1, int n, const char *s2) {