From patchwork Fri Jun 19 10:08:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Alrae X-Patchwork-Id: 486642 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B929D140134 for ; Fri, 19 Jun 2015 20:11:49 +1000 (AEST) Received: from localhost ([::1]:57219 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5tH1-0006pz-IK for incoming@patchwork.ozlabs.org; Fri, 19 Jun 2015 06:11:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5tEg-00031U-9o for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:09:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5tEc-0002r5-KP for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:09:22 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:62316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5tEc-0002ql-Cd for qemu-devel@nongnu.org; Fri, 19 Jun 2015 06:09:18 -0400 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 3D354D7522279; Fri, 19 Jun 2015 11:09:15 +0100 (IST) Received: from lalrae-linux.kl.imgtec.org (192.168.14.163) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 19 Jun 2015 11:09:17 +0100 From: Leon Alrae To: Date: Fri, 19 Jun 2015 11:08:42 +0100 Message-ID: <1434708524-25434-4-git-send-email-leon.alrae@imgtec.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1434708524-25434-1-git-send-email-leon.alrae@imgtec.com> References: <1434708524-25434-1-git-send-email-leon.alrae@imgtec.com> MIME-Version: 1.0 X-Originating-IP: [192.168.14.163] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 195.59.15.196 Cc: matthew.fortune@imgtec.com, aurelien@aurel32.net Subject: [Qemu-devel] [PATCH v3 3/5] target-mips: remove identical code in different branch X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno --- target-mips/translate.c | 25 ++++--------------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 1d128ee..6fd6dd9 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -11852,11 +11852,7 @@ static int decode_mips16_opc (CPUMIPSState *env, DisasContext *ctx) * when in debug mode... */ check_insn(ctx, ISA_MIPS32); - if (!(ctx->hflags & MIPS_HFLAG_DM)) { - generate_exception(ctx, EXCP_DBp); - } else { - generate_exception(ctx, EXCP_DBp); - } + generate_exception(ctx, EXCP_DBp); break; case RR_SLT: gen_slt(ctx, OPC_SLT, 24, rx, ry); @@ -12707,11 +12703,7 @@ static void gen_pool16c_insn(DisasContext *ctx) * when in debug mode... */ check_insn(ctx, ISA_MIPS32); - if (!(ctx->hflags & MIPS_HFLAG_DM)) { - generate_exception(ctx, EXCP_DBp); - } else { - generate_exception(ctx, EXCP_DBp); - } + generate_exception(ctx, EXCP_DBp); break; case JRADDIUSP + 0: case JRADDIUSP + 1: @@ -13076,11 +13068,7 @@ static void gen_pool32axf (CPUMIPSState *env, DisasContext *ctx, int rt, int rs) break; case SDBBP: check_insn(ctx, ISA_MIPS32); - if (!(ctx->hflags & MIPS_HFLAG_DM)) { - generate_exception(ctx, EXCP_DBp); - } else { - generate_exception(ctx, EXCP_DBp); - } + generate_exception(ctx, EXCP_DBp); break; default: goto pool32axf_invalid; @@ -16849,12 +16837,7 @@ static void decode_opc_special2_legacy(CPUMIPSState *env, DisasContext *ctx) * when in debug mode... */ check_insn(ctx, ISA_MIPS32); - if (!(ctx->hflags & MIPS_HFLAG_DM)) { - generate_exception(ctx, EXCP_DBp); - } else { - generate_exception(ctx, EXCP_DBp); - } - /* Treat as NOP. */ + generate_exception(ctx, EXCP_DBp); break; #if defined(TARGET_MIPS64) case OPC_DCLO: