From patchwork Tue May 6 06:08:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Edgar E. Iglesias" X-Patchwork-Id: 346022 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E03C71412F3 for ; Tue, 6 May 2014 16:11:38 +1000 (EST) Received: from localhost ([::1]:33029 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhYbI-0003sz-Ne for incoming@patchwork.ozlabs.org; Tue, 06 May 2014 02:11:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhYar-0003Dq-0P for qemu-devel@nongnu.org; Tue, 06 May 2014 02:11:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhYak-0000g5-JU for qemu-devel@nongnu.org; Tue, 06 May 2014 02:11:08 -0400 Received: from mail-qc0-x235.google.com ([2607:f8b0:400d:c01::235]:47299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhYak-0000fu-F7 for qemu-devel@nongnu.org; Tue, 06 May 2014 02:11:02 -0400 Received: by mail-qc0-f181.google.com with SMTP id m20so5749801qcx.12 for ; Mon, 05 May 2014 23:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PnXm1MDzbFm7jfo8FHwuZN6E7zRKZIXdErZtM/ZHZJU=; b=r4BJwL93PzUDKfXxkER476YCZkjCACvO5tCDgONykbRrRMqL2zsQxKrOBmLsXgDMmr yMkCiCZxhVgKIhwv9MG44pX2XpDoWi730IWUBujdiUzgMxRiclTKhuoDfn7YPTBzxYKQ 9q3On5UKe63XzaPYmFh3lFVhMyk7+fuHCT+bGDLPOx6AcLnExTBclHO7E1UEeT7HjioG pfbFLPFbE6ajPsaj41efEFrUCsXSddmzZkX9XqDpCEIgzgdShbqVB7fgcOzaet/luaND QuIQiSkqPD7/VM00s9l/Tv2TFvKVK05ZmkGZfylKJqeM41s59b1vCh+4LmM6YdXWbkux 8vog== X-Received: by 10.224.38.138 with SMTP id b10mr11490475qae.98.1399356662177; Mon, 05 May 2014 23:11:02 -0700 (PDT) Received: from localhost ([203.126.243.116]) by mx.google.com with ESMTPSA id d89sm10311758qga.2.2014.05.05.23.10.57 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 05 May 2014 23:11:01 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Tue, 6 May 2014 16:08:07 +1000 Message-Id: <1399356506-5609-4-git-send-email-edgar.iglesias@gmail.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1399356506-5609-1-git-send-email-edgar.iglesias@gmail.com> References: <1399356506-5609-1-git-send-email-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c01::235 Cc: rob.herring@linaro.org, peter.crosthwaite@xilinx.com, john.williams@xilinx.com, alex.bennee@linaro.org, agraf@suse.de Subject: [Qemu-devel] [PATCH v1 03/22] target-arm: Make esr_el1 an array X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: "Edgar E. Iglesias" No functional change. Prepares for future addtion of EL2 and 3 versions of this reg. Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h | 3 ++- target-arm/helper-a64.c | 4 ++-- target-arm/helper.c | 11 ++++++----- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index eb7a0f5..2a068ec 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -186,7 +186,8 @@ typedef struct CPUARMState { uint32_t pmsav5_data_ap; /* PMSAv5 MPU data access permissions */ uint32_t pmsav5_insn_ap; /* PMSAv5 MPU insn access permissions */ uint32_t ifsr_el2; /* Fault status registers. */ - uint64_t esr_el1; +#define ESR_EL_IDX(x) (x - 1) + uint64_t esr_el[1]; uint32_t c6_region[8]; /* MPU base/size registers. */ uint64_t far_el1; /* Fault address registers. */ uint64_t par_el1; /* Translation result. */ diff --git a/target-arm/helper-a64.c b/target-arm/helper-a64.c index 5adf2b5..4bee075 100644 --- a/target-arm/helper-a64.c +++ b/target-arm/helper-a64.c @@ -464,7 +464,7 @@ void aarch64_cpu_do_interrupt(CPUState *cs) env->exception.syndrome); } - env->cp15.esr_el1 = env->exception.syndrome; + env->cp15.esr_el[ESR_EL_IDX(1)] = env->exception.syndrome; env->cp15.far_el1 = env->exception.vaddress; switch (cs->exception_index) { @@ -495,7 +495,7 @@ void aarch64_cpu_do_interrupt(CPUState *cs) } else { env->banked_spsr[0] = cpsr_read(env); if (!env->thumb) { - env->cp15.esr_el1 |= 1 << 25; + env->cp15.esr_el[ESR_EL_IDX(1)] |= 1 << 25; } env->elr_el[ELR_EL_IDX(1)] = env->regs[15]; diff --git a/target-arm/helper.c b/target-arm/helper.c index 3457d3e..c86fab6 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -1452,7 +1452,7 @@ static void vmsa_ttbr_write(CPUARMState *env, const ARMCPRegInfo *ri, static const ARMCPRegInfo vmsa_cp_reginfo[] = { { .name = "DFSR", .cp = 15, .crn = 5, .crm = 0, .opc1 = 0, .opc2 = 0, .access = PL1_RW, .type = ARM_CP_NO_MIGRATE, - .fieldoffset = offsetoflow32(CPUARMState, cp15.esr_el1), + .fieldoffset = offsetoflow32(CPUARMState, cp15.esr_el[ESR_EL_IDX(1)]), .resetfn = arm_cp_reset_ignore, }, { .name = "IFSR", .cp = 15, .crn = 5, .crm = 0, .opc1 = 0, .opc2 = 1, .access = PL1_RW, @@ -1460,7 +1460,8 @@ static const ARMCPRegInfo vmsa_cp_reginfo[] = { { .name = "ESR_EL1", .state = ARM_CP_STATE_AA64, .opc0 = 3, .crn = 5, .crm = 2, .opc1 = 0, .opc2 = 0, .access = PL1_RW, - .fieldoffset = offsetof(CPUARMState, cp15.esr_el1), .resetvalue = 0, }, + .fieldoffset = offsetof(CPUARMState, cp15.esr_el[ESR_EL_IDX(1)]), + .resetvalue = 0, }, { .name = "TTBR0_EL1", .state = ARM_CP_STATE_BOTH, .opc0 = 3, .crn = 2, .crm = 0, .opc1 = 0, .opc2 = 0, .access = PL1_RW, .fieldoffset = offsetof(CPUARMState, cp15.ttbr0_el1), @@ -1521,7 +1522,7 @@ static void omap_cachemaint_write(CPUARMState *env, const ARMCPRegInfo *ri, static const ARMCPRegInfo omap_cp_reginfo[] = { { .name = "DFSR", .cp = 15, .crn = 5, .crm = CP_ANY, .opc1 = CP_ANY, .opc2 = CP_ANY, .access = PL1_RW, .type = ARM_CP_OVERRIDE, - .fieldoffset = offsetoflow32(CPUARMState, cp15.esr_el1), + .fieldoffset = offsetoflow32(CPUARMState, cp15.esr_el[ESR_EL_IDX(1)]), .resetvalue = 0, }, { .name = "", .cp = 15, .crn = 15, .crm = 0, .opc1 = 0, .opc2 = 0, .access = PL1_RW, .type = ARM_CP_NOP }, @@ -3331,11 +3332,11 @@ void arm_cpu_do_interrupt(CPUState *cs) offset = 4; break; case EXCP_DATA_ABORT: - env->cp15.esr_el1 = env->exception.fsr; + env->cp15.esr_el[ESR_EL_IDX(1)] = env->exception.fsr; env->cp15.far_el1 = deposit64(env->cp15.far_el1, 0, 32, env->exception.vaddress); qemu_log_mask(CPU_LOG_INT, "...with DFSR 0x%x DFAR 0x%x\n", - (uint32_t)env->cp15.esr_el1, + (uint32_t)env->cp15.esr_el[ESR_EL_IDX(1)], (uint32_t)env->exception.vaddress); new_mode = ARM_CPU_MODE_ABT; addr = 0x10;