From patchwork Fri Aug 23 18:52:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Herv=C3=A9_Poussineau?= X-Patchwork-Id: 269511 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A76852C0092 for ; Sat, 24 Aug 2013 04:52:14 +1000 (EST) Received: from localhost ([::1]:38287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCwSy-0002NP-K7 for incoming@patchwork.ozlabs.org; Fri, 23 Aug 2013 14:52:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCwSa-0002NJ-4F for qemu-devel@nongnu.org; Fri, 23 Aug 2013 14:51:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCwSU-0002Ua-JR for qemu-devel@nongnu.org; Fri, 23 Aug 2013 14:51:48 -0400 Received: from smtp4-g21.free.fr ([2a01:e0c:1:1599::13]:48897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCwSU-0002Tw-0Q for qemu-devel@nongnu.org; Fri, 23 Aug 2013 14:51:42 -0400 Received: from localhost.localdomain (unknown [82.227.227.196]) by smtp4-g21.free.fr (Postfix) with ESMTP id 2E3914C8027; Fri, 23 Aug 2013 20:51:35 +0200 (CEST) From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= To: qemu-devel@nongnu.org Date: Fri, 23 Aug 2013 20:52:51 +0200 Message-Id: <1377283973-9320-2-git-send-email-hpoussin@reactos.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1377283973-9320-1-git-send-email-hpoussin@reactos.org> References: <1377283973-9320-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:e0c:1:1599::13 Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= , "Michael S . Tsirkin" Subject: [Qemu-devel] [PATCH 1/3] pci: remove explicit check to 64K ioport size X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This check is useless, as bigger addresses will be ignored when added to 'io' MemoryRegion, which has a size of 64K. However, on architectures which have memory-mapped I/O, PCI I/O BARs can be mapped to an I/O address which is bigger than 64K. Signed-off-by: Hervé Poussineau --- hw/pci/pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 4c004f5..54cd43d 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1033,8 +1033,7 @@ static pcibus_t pci_bar_address(PCIDevice *d, } new_addr = pci_get_long(d->config + bar) & ~(size - 1); last_addr = new_addr + size - 1; - /* NOTE: we have only 64K ioports on PC */ - if (last_addr <= new_addr || new_addr == 0 || last_addr > UINT16_MAX) { + if (last_addr <= new_addr || new_addr == 0) { return PCI_BAR_UNMAPPED; } return new_addr;