From patchwork Fri Feb 22 15:50:55 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Liguori X-Patchwork-Id: 222551 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4962B2C0299 for ; Sat, 23 Feb 2013 02:51:17 +1100 (EST) Received: from localhost ([::1]:41556 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8uu3-0003q0-IO for incoming@patchwork.ozlabs.org; Fri, 22 Feb 2013 10:51:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8utv-0003pa-So for qemu-devel@nongnu.org; Fri, 22 Feb 2013 10:51:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U8utt-0007OD-Nn for qemu-devel@nongnu.org; Fri, 22 Feb 2013 10:51:07 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:45661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U8utt-0007O5-6G for qemu-devel@nongnu.org; Fri, 22 Feb 2013 10:51:05 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 23 Feb 2013 01:49:13 +1000 Received: from d23dlp03.au.ibm.com (202.81.31.214) by e23smtp08.au.ibm.com (202.81.31.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sat, 23 Feb 2013 01:49:11 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 2F68E357804E for ; Sat, 23 Feb 2013 02:50:58 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r1MFcZKG58785886 for ; Sat, 23 Feb 2013 02:38:35 +1100 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r1MFovTL027694 for ; Sat, 23 Feb 2013 02:50:57 +1100 Received: from titi.austin.rr.com (sig-9-49-153-3.mts.ibm.com [9.49.153.3]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r1MFotQv027676; Sat, 23 Feb 2013 02:50:56 +1100 From: Anthony Liguori To: qemu-devel@nongnu.org Date: Fri, 22 Feb 2013 09:50:55 -0600 Message-Id: <1361548255-13465-1-git-send-email-aliguori@us.ibm.com> X-Mailer: git-send-email 1.8.0 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13022215-5140-0000-0000-000002CC34F8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 202.81.31.141 Cc: Anthony Liguori Subject: [Qemu-devel] [PATCH v2] ui/gtk: require at least GTK 2.18 and VTE 0.26 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This gives us the bare amount of features we need. We can add work arounds for older versions and lower the requirement but this should be a good starting point. Suggested-by: Daniel Berrange Signed-off-by: Anthony Liguori --- v1 -> v2 - tremendous simplification suggested by danpb --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 0dadd31..0eb25dd 100755 --- a/configure +++ b/configure @@ -1644,8 +1644,8 @@ fi # GTK probe if test "$gtk" != "no"; then - if $pkg_config gtk+-2.0 --modversion >/dev/null 2>/dev/null && \ - $pkg_config vte --modversion >/dev/null 2>/dev/null; then + if $pkg_config --exists 'gtk+-2.0 >= 2.18.0' && \ + $pkg_config --exists 'vte >= 0.26.0'; then gtk_cflags=`$pkg_config --cflags gtk+-2.0 2>/dev/null` gtk_libs=`$pkg_config --libs gtk+-2.0 2>/dev/null` vte_cflags=`$pkg_config --cflags vte 2>/dev/null`