From patchwork Mon Feb 4 21:23:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anthony Liguori X-Patchwork-Id: 218072 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0A6AC2C02F1 for ; Tue, 5 Feb 2013 08:24:59 +1100 (EST) Received: from localhost ([::1]:35399 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2TX7-0006Ce-4h for incoming@patchwork.ozlabs.org; Mon, 04 Feb 2013 16:24:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2TWy-0006CH-M2 for qemu-devel@nongnu.org; Mon, 04 Feb 2013 16:24:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U2TWx-0004bK-AH for qemu-devel@nongnu.org; Mon, 04 Feb 2013 16:24:48 -0500 Received: from e33.co.us.ibm.com ([32.97.110.151]:46434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2TWx-0004b1-3o for qemu-devel@nongnu.org; Mon, 04 Feb 2013 16:24:47 -0500 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 Feb 2013 14:24:44 -0700 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 4 Feb 2013 14:24:42 -0700 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 463B01FF0038 for ; Mon, 4 Feb 2013 14:24:40 -0700 (MST) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r14LOdc9507644 for ; Mon, 4 Feb 2013 14:24:39 -0700 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r14LO1JV031073 for ; Mon, 4 Feb 2013 14:24:02 -0700 Received: from titi.austin.rr.com ([9.80.49.245]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r14LO0vu030868; Mon, 4 Feb 2013 14:24:00 -0700 From: Anthony Liguori To: qemu-devel@nongnu.org Date: Mon, 4 Feb 2013 15:23:59 -0600 Message-Id: <1360013039-20444-1-git-send-email-aliguori@us.ibm.com> X-Mailer: git-send-email 1.8.0 MIME-Version: 1.0 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13020421-2398-0000-0000-000010B03DA4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 32.97.110.151 Cc: Cornelia Huck , Stefan Weil , Anthony Liguori Subject: [Qemu-devel] [PATCH] s390x: silence warning from GCC on uninitialized values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org As best I can tell, this is a false positive. [aliguori@ccnode4 qemu-s390]$ make CC s390x-softmmu/target-s390x/helper.o /home/aliguori/git/qemu/target-s390x/helper.c: In function ‘do_interrupt’: /home/aliguori/git/qemu/target-s390x/helper.c:673:17: error: ‘addr’ may be used uninitialized in this function [-Werror=maybe-uninitialized] /home/aliguori/git/qemu/target-s390x/helper.c:620:20: note: ‘addr’ was declared here /home/aliguori/git/qemu/target-s390x/helper.c:673:17: error: ‘mask’ may be used uninitialized in this function [-Werror=maybe-uninitialized] /home/aliguori/git/qemu/target-s390x/helper.c:620:14: note: ‘mask’ was declared here cc1: all warnings being treated as errors make[1]: *** [target-s390x/helper.o] Error 1 make: *** [subdir-s390x-softmmu] Error 2 Cc: Cornelia Huck Cc: Stefan Weil Signed-off-by: Anthony Liguori --- target-s390x/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-s390x/helper.c b/target-s390x/helper.c index 8bd84ef..043feb2 100644 --- a/target-s390x/helper.c +++ b/target-s390x/helper.c @@ -617,7 +617,7 @@ static void do_ext_interrupt(CPUS390XState *env) static void do_io_interrupt(CPUS390XState *env) { - uint64_t mask, addr; + uint64_t mask = 0, addr = 0; LowCore *lowcore; IOIntQueue *q; uint8_t isc;