| Message ID | 1327080085-8673-1-git-send-email-stefano.stabellini@eu.citrix.com |
|---|---|
| State | New |
| Headers | show |
On 01/20/2012 11:21 AM, Stefano Stabellini wrote: > From: Anthony PERARD<anthony.perard@citrix.com> > > In the Xen case, the guest RAM is not handle by QEMU, and it is saved by > Xen tools. > So, we just avoid to register the RAM save state handler. > > Signed-off-by: Anthony PERARD<anthony.perard@citrix.com> > Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com> > --- > vl.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/vl.c b/vl.c > index ba55b35..6f0435b 100644 > --- a/vl.c > +++ b/vl.c > @@ -3270,8 +3270,10 @@ int main(int argc, char **argv, char **envp) > default_drive(default_sdcard, snapshot, machine->use_scsi, > IF_SD, 0, SD_OPTS); > > - register_savevm_live(NULL, "ram", 0, 4, NULL, ram_save_live, NULL, > - ram_load, NULL); > + if (!xen_enabled()) { > + register_savevm_live(NULL, "ram", 0, 4, NULL, ram_save_live, NULL, > + ram_load, NULL); > + } Why not introduce new Xen specific commands like I suggested on IRC? This sort of change is extremely non-intuitive. We should do as much as we can to avoid magic #ifdefs like this. Regards, Anthony Liguori > > if (nb_numa_nodes> 0) { > int i;
diff --git a/vl.c b/vl.c index ba55b35..6f0435b 100644 --- a/vl.c +++ b/vl.c @@ -3270,8 +3270,10 @@ int main(int argc, char **argv, char **envp) default_drive(default_sdcard, snapshot, machine->use_scsi, IF_SD, 0, SD_OPTS); - register_savevm_live(NULL, "ram", 0, 4, NULL, ram_save_live, NULL, - ram_load, NULL); + if (!xen_enabled()) { + register_savevm_live(NULL, "ram", 0, 4, NULL, ram_save_live, NULL, + ram_load, NULL); + } if (nb_numa_nodes > 0) { int i;