From patchwork Wed Sep 8 14:21:16 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Litke X-Patchwork-Id: 64157 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 34987B6EFE for ; Thu, 9 Sep 2010 00:35:16 +1000 (EST) Received: from localhost ([127.0.0.1]:47998 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OtLk1-0004wm-4t for incoming@patchwork.ozlabs.org; Wed, 08 Sep 2010 10:35:13 -0400 Received: from [140.186.70.92] (port=49444 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OtLWc-00045X-8V for qemu-devel@nongnu.org; Wed, 08 Sep 2010 10:21:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OtLWa-00078y-SF for qemu-devel@nongnu.org; Wed, 08 Sep 2010 10:21:21 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:39220) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OtLWa-00078n-NB for qemu-devel@nongnu.org; Wed, 08 Sep 2010 10:21:20 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e36.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id o88EHPXB004781 for ; Wed, 8 Sep 2010 08:17:25 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id o88ELJDq192458 for ; Wed, 8 Sep 2010 08:21:19 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o88ELIob001672 for ; Wed, 8 Sep 2010 08:21:18 -0600 Received: from localhost.localdomain (aglitke.rchland.ibm.com [9.10.86.224]) by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id o88ELH6r001572; Wed, 8 Sep 2010 08:21:17 -0600 From: Adam Litke To: Amit Shah , Anthony Liguori Date: Wed, 8 Sep 2010 09:21:16 -0500 Message-Id: <1283955676-25119-1-git-send-email-agl@us.ibm.com> X-Mailer: git-send-email 1.6.1.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Cc: Adam Litke , Paolo Bonzini , Luiz Capitulino , qemu list , Markus Armbruster Subject: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The addition of memory stats reporting to the virtio balloon causes the 'info balloon' command to become asynchronous. This is a regression because in some cases it can hang the user monitor. Disable this feature until a better interface for asynchronous commands can be worked out. Signed-off-by: Adam Litke --- hw/virtio-balloon.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c index 9fe3886..dcdada6 100644 --- a/hw/virtio-balloon.c +++ b/hw/virtio-balloon.c @@ -190,7 +190,17 @@ static void virtio_balloon_set_config(VirtIODevice *vdev, static uint32_t virtio_balloon_get_features(VirtIODevice *vdev, uint32_t f) { - f |= (1 << VIRTIO_BALLOON_F_STATS_VQ); + /* + * The addition of memory stats reporting to the virtio balloon causes + * the 'info balloon' command to become asynchronous. This is a regression + * because in some cases it can hang the user monitor. + * + * Disable this feature until a better interface for asynchronous commands + * can be worked out. + * + * -aglitke + */ + /* f |= (1 << VIRTIO_BALLOON_F_STATS_VQ); */ return f; }