From patchwork Sat Mar 20 04:50:42 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryota OZAKI X-Patchwork-Id: 48198 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 18BACB7D14 for ; Sat, 20 Mar 2010 15:59:01 +1100 (EST) Received: from localhost ([127.0.0.1]:56389 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NsqhS-0005zE-0I for incoming@patchwork.ozlabs.org; Sat, 20 Mar 2010 00:54:14 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nsqg2-0005z9-EG for qemu-devel@nongnu.org; Sat, 20 Mar 2010 00:52:46 -0400 Received: from [199.232.76.173] (port=54200 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nsqg1-0005z1-Pn for qemu-devel@nongnu.org; Sat, 20 Mar 2010 00:52:45 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nsqg1-0006wW-3K for qemu-devel@nongnu.org; Sat, 20 Mar 2010 00:52:45 -0400 Received: from mail-yw0-f198.google.com ([209.85.211.198]:65171) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nsqg0-0006wS-TR for qemu-devel@nongnu.org; Sat, 20 Mar 2010 00:52:44 -0400 Received: by ywh36 with SMTP id 36so915108ywh.4 for ; Fri, 19 Mar 2010 21:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :message-id:x-mailer; bh=XNVLEqW1EAM2UlC3O+fBHax+YusqJs5cEh4ofKXOous=; b=k1m7/VoAnKNmaZ91YZVlrE/5EMGr3+RzaUmShPO0Fc7Gh6RGGTwGhMK6C0/Sxht5MB MdAfVMy1WKSG6smWZUeCkH3RPaz4QFhE7nGKcvOJ6KiT1N9epa0pdztwjomMpDVp+5Rd ek4jhEJrVrKYVxKyrLFNurTdsNRUTn79ETfxY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:x-mailer; b=xZdQaUV24v4k92sVvSuW5jcMPjzefQFDcDvXLjFSjV0Kf3ib782RdRPaaVcTsUfiYa 5UGqvNXcID6DBJxIRXEF5kMHZ5crAWwcq8IrZqIihDsk2WQ+c78LvJvOZhBCeF2GJGP5 4w1znoXB2tx4afu73LGz9uBxKEiF9tjQxLUtY= Received: by 10.101.28.7 with SMTP id f7mr63398anj.218.1269060763410; Fri, 19 Mar 2010 21:52:43 -0700 (PDT) Received: from localhost.localdomain (host105.nvlab.org [122.1.115.105]) by mx.google.com with ESMTPS id 7sm706097ywf.55.2010.03.19.21.52.41 (version=SSLv3 cipher=RC4-MD5); Fri, 19 Mar 2010 21:52:42 -0700 (PDT) From: Ryota Ozaki To: qemu-devel@nongnu.org Date: Sat, 20 Mar 2010 13:50:42 +0900 Message-Id: <1269060643-3321-1-git-send-email-ozaki.ryota@gmail.com> X-Mailer: git-send-email 1.6.5.2 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCH 1/2] qemu-nbd: Fix return value handling of bdrv_open X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org bdrv_open may return -errno so we have to check if the return value is '< 0', not '== -1'. --- qemu-nbd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index a393583..b89c361 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -333,7 +333,7 @@ int main(int argc, char **argv) if (bs == NULL) return 1; - if (bdrv_open(bs, argv[optind], flags) == -1) + if (bdrv_open(bs, argv[optind], flags) < 0) return 1; fd_size = bs->total_sectors * 512;