diff mbox

Fix hanging user monitor when using balloon command

Message ID 1266005679.3474.5.camel@aglitke
State New
Headers show

Commit Message

Adam Litke Feb. 12, 2010, 8:14 p.m. UTC 
Hi Anthony.  I wonder if there was a problem when importing my async
command handler patchset.  Since the 'balloon' command completes
immediately, it must call the completion callback before returning.
That call was missing but is added by the patch below.

Comments

Anthony Liguori Feb. 12, 2010, 8:50 p.m. UTC | #1 
On 02/12/2010 02:14 PM, Adam Litke wrote:
> Hi Anthony.  I wonder if there was a problem when importing my async
> command handler patchset.  Since the 'balloon' command completes
> immediately, it must call the completion callback before returning.
> That call was missing but is added by the patch below.
>    

Needs a Signed-off-by.  I don't recall any fuzz with your patch but that 
was a few hundred patches ago :-)

Regards,

Anthony Liguori

> diff --git a/monitor.c b/monitor.c
> index ae125b8..f94794d 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params,
>           return -1;
>       }
>
> +    cb(opaque, NULL);
>       return 0;
>   }
>
>
diff mbox

Patch

diff --git a/monitor.c b/monitor.c
index ae125b8..f94794d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2258,6 +2258,7 @@  static int do_balloon(Monitor *mon, const QDict *params,
         return -1;
     }
 
+    cb(opaque, NULL);
     return 0;
 }