| Message ID | 20240220184145.106107-1-ines.varhol@telecom-paris.fr |
|---|---|
| Headers | show |
| Series | hw/arm: Fix STM32L4x5 EXTI to CPU irq fan-in connections | expand |
On Tue, 20 Feb 2024 at 18:41, Inès Varhol <ines.varhol@telecom-paris.fr> wrote: > > The original code was connecting several outbounds qemu_irqs to the > same qemu_irq without using a TYPE_OR_IRQ. > > This patch fixes the issue by using OR gates when necessary (1st commit). > > I attempted to check that the problem is fixed by using a QTest (2nd commit) > but actually the test is passing even before the fix : > when any fan-in input line is raised, the output is raised too. > > Changes from v1 : > - using SoC State fields for EXTI OR gates > - correcting length of array `exti_or_gates_num_lines_in` > - using a for loop in the test for more clarity > - correcting typo in test comment > > Fixes: 52671f69f7a4 ("[PATCH v8 0/3] Add device STM32L4x5 EXTI") > Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr> > > Inès Varhol (2): > hw/arm: Use TYPE_OR_IRQ when connecting STM32L4x5 EXTI fan-in IRQs > tests/qtest: Check that EXTI fan-in irqs are correctly connected Applied to target-arm.next, thanks. -- PMM
The original code was connecting several outbounds qemu_irqs to the same qemu_irq without using a TYPE_OR_IRQ. This patch fixes the issue by using OR gates when necessary (1st commit). I attempted to check that the problem is fixed by using a QTest (2nd commit) but actually the test is passing even before the fix : when any fan-in input line is raised, the output is raised too. Changes from v1 : - using SoC State fields for EXTI OR gates - correcting length of array `exti_or_gates_num_lines_in` - using a for loop in the test for more clarity - correcting typo in test comment Fixes: 52671f69f7a4 ("[PATCH v8 0/3] Add device STM32L4x5 EXTI") Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr> Inès Varhol (2): hw/arm: Use TYPE_OR_IRQ when connecting STM32L4x5 EXTI fan-in IRQs tests/qtest: Check that EXTI fan-in irqs are correctly connected include/hw/arm/stm32l4x5_soc.h | 4 ++ hw/arm/stm32l4x5_soc.c | 80 +++++++++++++++++++++++++++---- tests/qtest/stm32l4x5_exti-test.c | 37 ++++++++++++++ 3 files changed, 111 insertions(+), 10 deletions(-)