mbox series

[0/2] hw/arm: Fix STM32L4x5 EXTI to CPU irq fan-in connections

Message ID 20240212163446.227802-1-ines.varhol@telecom-paris.fr
Headers show
Series hw/arm: Fix STM32L4x5 EXTI to CPU irq fan-in connections | expand

Message

Inès Varhol Feb. 12, 2024, 4:31 p.m. UTC
The original code was connecting several outbounds qemu_irqs to the
same qemu_irq without using a TYPE_OR_IRQ.

This patch fixes the issue by using OR gates when necessary (1st commit).

I attempted to check that the problem is fixed by using a QTest (2nd commit)
but actually the test is passing even before the fix :
when any fan-in input line is raised, the output is raised too.

Fixes: 52671f69f7a4 ("[PATCH v8 0/3] Add device STM32L4x5 EXTI")
Signed-off-by: Inès Varhol <ines.varhol@telecom-paris.fr>

Inès Varhol (2):
  hw/arm: Use TYPE_OR_IRQ when connecting STM32L4x5 EXTI fan-in IRQs
  tests/qtest: Check that EXTI fan-in irqs are correctly connected

 hw/arm/stm32l4x5_soc.c            | 69 ++++++++++++++++++----
 tests/qtest/stm32l4x5_exti-test.c | 97 +++++++++++++++++++++++++++++++
 2 files changed, 156 insertions(+), 10 deletions(-)