mbox series

[00/14] hw/Kconfig: Fixes when running ./configure --without-default-devices

Message ID 20190316200818.8265-1-philmd@redhat.com
Headers show
Series hw/Kconfig: Fixes when running ./configure --without-default-devices | expand

Message

Philippe Mathieu-Daudé March 16, 2019, 8:08 p.m. UTC
Hi,

This series contains Kconfig fixes to be able to run binaries
built using: './configure --without-default-devices'.

Regards,

Phil.

Philippe Mathieu-Daudé (14):
  hw/isa/Kconfig: PIIX4 southbridge requires USB UHCI
  hw/isa/Kconfig: i82378 SuperIO requires PC speaker device
  hw/i386/Kconfig: Q35 machine requires e1000e network card
  hw/i386/Kconfig: isapc machine requires VGA display
  hw/i386/Kconfig: isapc machine requires e1000 network card
  hw/mips/Kconfig: Malta machine requires the pcnet network card
  hw/mips/Kconfig: Fulong 2e board requires ati-vga/rtl8139 PCI devices
  hw/ppc/Kconfig: Bamboo machine requires e1000 network card
  hw/ppc/Kconfig: e500 based machines require virtio-net-pci device
  hw/s390x/Kconfig: s390x machines require virtio-net-ccw device
  hw/sparc/Kconfig: SPARCstation machine requires the TCX display
  hw/sh4/Kconfig: r2d machine requires the rtl8139 network card
  hw/hppa/Kconfig: Dino board requires e1000 network card
  hw/alpha/Kconfig: DP264 hardware requires e1000 network card

 default-configs/mips-softmmu-common.mak | 1 +
 default-configs/mips64el-softmmu.mak    | 2 ++
 default-configs/sparc-softmmu.mak       | 1 -
 hw/alpha/Kconfig                        | 1 +
 hw/hppa/Kconfig                         | 1 +
 hw/i386/Kconfig                         | 3 +++
 hw/isa/Kconfig                          | 2 ++
 hw/ppc/Kconfig                          | 2 ++
 hw/s390x/Kconfig                        | 1 +
 hw/sh4/Kconfig                          | 1 +
 hw/sparc/Kconfig                        | 2 +-
 11 files changed, 15 insertions(+), 2 deletions(-)

Comments

Paolo Bonzini March 19, 2019, 3:02 p.m. UTC | #1
On 16/03/19 21:08, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> This series contains Kconfig fixes to be able to run binaries
> built using: './configure --without-default-devices'.


Hi, I applied 1/2/3/6/7/8/9/12/13/14, with select replaced by imply.
For patches 4/5, the right place to modify is  "config PC" in addition
to replacing select with imply.

Patch 10 should not be needed since there is no equivalent of
CONFIG_PCI_DEVICES for virtio.

For patch 11 (and 7) I have posted two patches to honor "-vga none", so
that the boards can be configured with --without-default-devices too (in
the case of Fulong2e, this will of course apply only after it is
converted to Kconfig).

Paolo

> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (14):
>   hw/isa/Kconfig: PIIX4 southbridge requires USB UHCI
>   hw/isa/Kconfig: i82378 SuperIO requires PC speaker device
>   hw/i386/Kconfig: Q35 machine requires e1000e network card
>   hw/i386/Kconfig: isapc machine requires VGA display
>   hw/i386/Kconfig: isapc machine requires e1000 network card
>   hw/mips/Kconfig: Malta machine requires the pcnet network card
>   hw/mips/Kconfig: Fulong 2e board requires ati-vga/rtl8139 PCI devices
>   hw/ppc/Kconfig: Bamboo machine requires e1000 network card
>   hw/ppc/Kconfig: e500 based machines require virtio-net-pci device
>   hw/s390x/Kconfig: s390x machines require virtio-net-ccw device
>   hw/sparc/Kconfig: SPARCstation machine requires the TCX display
>   hw/sh4/Kconfig: r2d machine requires the rtl8139 network card
>   hw/hppa/Kconfig: Dino board requires e1000 network card
>   hw/alpha/Kconfig: DP264 hardware requires e1000 network card
> 
>  default-configs/mips-softmmu-common.mak | 1 +
>  default-configs/mips64el-softmmu.mak    | 2 ++
>  default-configs/sparc-softmmu.mak       | 1 -
>  hw/alpha/Kconfig                        | 1 +
>  hw/hppa/Kconfig                         | 1 +
>  hw/i386/Kconfig                         | 3 +++
>  hw/isa/Kconfig                          | 2 ++
>  hw/ppc/Kconfig                          | 2 ++
>  hw/s390x/Kconfig                        | 1 +
>  hw/sh4/Kconfig                          | 1 +
>  hw/sparc/Kconfig                        | 2 +-
>  11 files changed, 15 insertions(+), 2 deletions(-)
>
Philippe Mathieu-Daudé March 19, 2019, 4:45 p.m. UTC | #2
Le mar. 19 mars 2019 16:03, Paolo Bonzini <pbonzini@redhat.com> a écrit :

> On 16/03/19 21:08, Philippe Mathieu-Daudé wrote:
> > Hi,
> >
> > This series contains Kconfig fixes to be able to run binaries
> > built using: './configure --without-default-devices'.
>
>
> Hi, I applied 1/2/3/6/7/8/9/12/13/14, with select replaced by imply.
> For patches 4/5, the right place to modify is  "config PC" in addition
> to replacing select with imply.
>

Ok thanks!


> Patch 10 should not be needed since there is no equivalent of
> CONFIG_PCI_DEVICES for virtio.
>

Ok.


> For patch 11 (and 7) I have posted two patches to honor "-vga none", so
> that the boards can be configured with --without-default-devices too (in
> the case of Fulong2e, this will of course apply only after it is
> converted to Kconfig).
>

Ok,  thanks.

Phil.


> Paolo
>
> > Regards,
> >
> > Phil.
> >
> > Philippe Mathieu-Daudé (14):
> >   hw/isa/Kconfig: PIIX4 southbridge requires USB UHCI
> >   hw/isa/Kconfig: i82378 SuperIO requires PC speaker device
> >   hw/i386/Kconfig: Q35 machine requires e1000e network card
> >   hw/i386/Kconfig: isapc machine requires VGA display
> >   hw/i386/Kconfig: isapc machine requires e1000 network card
> >   hw/mips/Kconfig: Malta machine requires the pcnet network card
> >   hw/mips/Kconfig: Fulong 2e board requires ati-vga/rtl8139 PCI devices
> >   hw/ppc/Kconfig: Bamboo machine requires e1000 network card
> >   hw/ppc/Kconfig: e500 based machines require virtio-net-pci device
> >   hw/s390x/Kconfig: s390x machines require virtio-net-ccw device
> >   hw/sparc/Kconfig: SPARCstation machine requires the TCX display
> >   hw/sh4/Kconfig: r2d machine requires the rtl8139 network card
> >   hw/hppa/Kconfig: Dino board requires e1000 network card
> >   hw/alpha/Kconfig: DP264 hardware requires e1000 network card
> >
> >  default-configs/mips-softmmu-common.mak | 1 +
> >  default-configs/mips64el-softmmu.mak    | 2 ++
> >  default-configs/sparc-softmmu.mak       | 1 -
> >  hw/alpha/Kconfig                        | 1 +
> >  hw/hppa/Kconfig                         | 1 +
> >  hw/i386/Kconfig                         | 3 +++
> >  hw/isa/Kconfig                          | 2 ++
> >  hw/ppc/Kconfig                          | 2 ++
> >  hw/s390x/Kconfig                        | 1 +
> >  hw/sh4/Kconfig                          | 1 +
> >  hw/sparc/Kconfig                        | 2 +-
> >  11 files changed, 15 insertions(+), 2 deletions(-)
> >
>
>
>