From patchwork Sun Mar 10 08:46:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuval Shaia X-Patchwork-Id: 1053986 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="wr0xX8XV"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44HFwP54dLz9s1B for ; Sun, 10 Mar 2019 20:16:21 +1100 (AEDT) Received: from localhost ([127.0.0.1]:42497 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2uZ9-0000Ub-HD for incoming@patchwork.ozlabs.org; Sun, 10 Mar 2019 05:16:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2u6A-0000XD-A4 for qemu-devel@nongnu.org; Sun, 10 Mar 2019 04:46:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2u69-0007Mk-FK for qemu-devel@nongnu.org; Sun, 10 Mar 2019 04:46:22 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:42094) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h2u69-0007Lv-5Q for qemu-devel@nongnu.org; Sun, 10 Mar 2019 04:46:21 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2A8dw0R120293; Sun, 10 Mar 2019 08:46:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id; s=corp-2018-07-02; bh=ClCQkOR14BVBf7eNpWfpK8T6yasNAO3fEJWKan8adEw=; b=wr0xX8XVoM9BJuZdIwwviTej98bF0YW6lGSlVxbvHOWlHUzb3Mhgz8TScI8SuKfySmB0 oU0mBc1wUjXPbEXePiSsLx7TGUUMiJQDaUmhr+sSQEkITjNICTa22GsiTyd0cXNTVT2s ousoLQKwWyOjayMW+tlqkY8trlwBL0VKfDR1YpH1zi+7ZtnESGANZKeLz3rt9VoHWHyG fCLmaKh2tzuQXORShVBB92Di6O8eELKTkfcVJp42deCKGZNVRULoQ/pGfiXTWoIilJxL zOqaUt5AVpZy6mCiQmEe0yPqMiu6mtOHp8yK5Hk3UQu//bPGd3ClhH0oaBW1JJLeXR0a QQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2r44wtth60-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 10 Mar 2019 08:46:18 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x2A8kIFZ001526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 10 Mar 2019 08:46:18 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x2A8kH9u025186; Sun, 10 Mar 2019 08:46:18 GMT Received: from localhost.localdomain (/77.138.186.148) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 10 Mar 2019 00:46:17 -0800 From: Yuval Shaia To: dgilbert@redhat.com, yuval.shaia@oracle.com, marcel.apfelbaum@gmail.com, armbru@redhat.com, qemu-devel@nongnu.org Date: Sun, 10 Mar 2019 10:46:00 +0200 Message-Id: <20190310084610.23077-1-yuval.shaia@oracle.com> X-Mailer: git-send-email 2.17.2 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9190 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903100069 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.86 Subject: [Qemu-devel] [PATCH v5 00/10] Misc fixes to pvrdma device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hi, Please review the following patch-set which consist of cosmetics fixes to device's user interface (traces, error_report and monitor) and some bug fixes. Thanks Markus, Eric, Marcel and David for your review Review is needed for patch #4 - "hw/pvrdma: Collect debugging statistics" v0 -> v1: * Explain why device attributes are exposed only in HMP interface. * Squash the 3 patches related to HMP interface into one. * Make monitor dump function simple. * Make HMP interface available only if pvrdma is included (detected by build robot). * Remove patch 03/10 ("Warn when too many consecutive poll CQ triggered on an empty CQ) and add the two counters to patch 0/7 (monitor). * Add Marcel's R-Bs. * Add mutex protection to cqe_ctx list. * Add two new patches. v1 -> v2: * Rename locked-lists to protected-lists in patch 2 and patch 6. * Add Marcel's R-Bs. v2 -> v3: * Address some 32 bit host compilation issues. v3 -> v4: * Per suggestion from Markus rebase HMP report on object_child_foreach_recursive(). * Strip off David's r-b from HMP patch (#4) because of the above. v4 -> v5: * Accept comments from Marcus and David * Rename RDMA device interface * Split patch #4 into 2 patches * Add some more counters * Add Marcus and David ack-by to hmp patch Yuval Shaia (10): hw/rdma: Switch to generic error reporting way hw/rdma: Introduce protected qlist hw/rdma: Protect against concurrent execution of poll_cq hw/pvrdma: Collect debugging statistics {hmp, hw/pvrdma}: Expose device internals via monitor interface hw/rdma: Free all MAD receive buffers when device is closed hw/rdma: Free all receive buffers when QP is destroyed hw/pvrdma: Delete unneeded function argument hw/pvrdma: Delete pvrdma_exit function hw/pvrdma: Unregister from shutdown notifier when device goes down hmp-commands-info.hx | 14 + hmp.c | 27 ++ hmp.h | 1 + hw/rdma/Makefile.objs | 2 +- hw/rdma/rdma.c | 30 +++ hw/rdma/rdma_backend.c | 483 +++++++++++++++++----------------- hw/rdma/rdma_backend.h | 3 +- hw/rdma/rdma_backend_defs.h | 10 +- hw/rdma/rdma_rm.c | 193 ++++++++------ hw/rdma/rdma_rm.h | 7 +- hw/rdma/rdma_rm_defs.h | 28 +- hw/rdma/rdma_utils.c | 83 +++++- hw/rdma/rdma_utils.h | 61 ++--- hw/rdma/trace-events | 32 ++- hw/rdma/vmw/pvrdma.h | 12 +- hw/rdma/vmw/pvrdma_cmd.c | 115 +++----- hw/rdma/vmw/pvrdma_dev_ring.c | 26 +- hw/rdma/vmw/pvrdma_main.c | 168 ++++++------ hw/rdma/vmw/pvrdma_qp_ops.c | 52 +--- hw/rdma/vmw/trace-events | 16 +- include/hw/rdma/rdma.h | 40 +++ 21 files changed, 796 insertions(+), 607 deletions(-) create mode 100644 hw/rdma/rdma.c create mode 100644 include/hw/rdma/rdma.h