mbox series

[v4,0/4] tests: Allow use of Ports bash and GNU sed extensions

Message ID 20190307145839.13128-1-philmd@redhat.com
Headers show
Series tests: Allow use of Ports bash and GNU sed extensions | expand

Message

Philippe Mathieu-Daudé March 7, 2019, 2:58 p.m. UTC
Hi Thomas,

This series contains few script cleanups which help to
run tests on OpenBSD.
Note, this is a split of the previous series, here restricted
to tests/.

Since v3:
- Do not use space in shebang (21st century update from Thomas)
- Added R-b

Since v2:
- Addressed Eric's comments (in code and commit descriptions)
- Added R-b

v3: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00943.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg07513.html

Philippe Mathieu-Daudé (4):
  tests/multiboot: Improve portability by searching bash in the $PATH
  tests/bios-tables: Improve portability by searching bash in the $PATH
  qemu-iotests: Improve portability by searching bash in the $PATH
  qemu-iotests: Ensure GNU sed is used

 tests/data/acpi/rebuild-expected-aml.sh |  2 +-
 tests/multiboot/run_test.sh             |  2 +-
 tests/qemu-iotests/001                  |  2 +-
 tests/qemu-iotests/002                  |  2 +-
 tests/qemu-iotests/003                  |  2 +-
 tests/qemu-iotests/004                  |  2 +-
 tests/qemu-iotests/005                  |  2 +-
 tests/qemu-iotests/007                  |  2 +-
 tests/qemu-iotests/008                  |  2 +-
 tests/qemu-iotests/009                  |  2 +-
 tests/qemu-iotests/010                  |  2 +-
 tests/qemu-iotests/011                  |  2 +-
 tests/qemu-iotests/012                  |  2 +-
 tests/qemu-iotests/013                  |  2 +-
 tests/qemu-iotests/014                  |  2 +-
 tests/qemu-iotests/015                  |  2 +-
 tests/qemu-iotests/017                  |  2 +-
 tests/qemu-iotests/018                  |  2 +-
 tests/qemu-iotests/019                  |  2 +-
 tests/qemu-iotests/020                  |  2 +-
 tests/qemu-iotests/021                  |  2 +-
 tests/qemu-iotests/022                  |  2 +-
 tests/qemu-iotests/023                  |  2 +-
 tests/qemu-iotests/024                  |  2 +-
 tests/qemu-iotests/025                  |  2 +-
 tests/qemu-iotests/026                  |  2 +-
 tests/qemu-iotests/027                  |  2 +-
 tests/qemu-iotests/028                  |  2 +-
 tests/qemu-iotests/029                  |  2 +-
 tests/qemu-iotests/031                  |  2 +-
 tests/qemu-iotests/032                  |  2 +-
 tests/qemu-iotests/033                  |  2 +-
 tests/qemu-iotests/034                  |  2 +-
 tests/qemu-iotests/035                  |  2 +-
 tests/qemu-iotests/036                  |  2 +-
 tests/qemu-iotests/037                  |  2 +-
 tests/qemu-iotests/038                  |  2 +-
 tests/qemu-iotests/039                  |  2 +-
 tests/qemu-iotests/042                  |  2 +-
 tests/qemu-iotests/043                  |  2 +-
 tests/qemu-iotests/046                  |  2 +-
 tests/qemu-iotests/047                  |  2 +-
 tests/qemu-iotests/048                  |  2 +-
 tests/qemu-iotests/049                  |  2 +-
 tests/qemu-iotests/050                  |  2 +-
 tests/qemu-iotests/051                  |  2 +-
 tests/qemu-iotests/052                  |  2 +-
 tests/qemu-iotests/053                  |  2 +-
 tests/qemu-iotests/054                  |  2 +-
 tests/qemu-iotests/058                  |  2 +-
 tests/qemu-iotests/059                  |  2 +-
 tests/qemu-iotests/060                  |  2 +-
 tests/qemu-iotests/061                  |  2 +-
 tests/qemu-iotests/062                  |  2 +-
 tests/qemu-iotests/063                  |  2 +-
 tests/qemu-iotests/064                  |  2 +-
 tests/qemu-iotests/066                  |  2 +-
 tests/qemu-iotests/067                  |  2 +-
 tests/qemu-iotests/068                  |  2 +-
 tests/qemu-iotests/069                  |  2 +-
 tests/qemu-iotests/070                  |  2 +-
 tests/qemu-iotests/071                  |  2 +-
 tests/qemu-iotests/072                  |  2 +-
 tests/qemu-iotests/073                  |  2 +-
 tests/qemu-iotests/074                  |  2 +-
 tests/qemu-iotests/075                  |  2 +-
 tests/qemu-iotests/076                  |  2 +-
 tests/qemu-iotests/077                  |  2 +-
 tests/qemu-iotests/078                  |  2 +-
 tests/qemu-iotests/079                  |  2 +-
 tests/qemu-iotests/080                  |  2 +-
 tests/qemu-iotests/081                  |  2 +-
 tests/qemu-iotests/082                  |  2 +-
 tests/qemu-iotests/083                  |  2 +-
 tests/qemu-iotests/084                  |  2 +-
 tests/qemu-iotests/085                  |  2 +-
 tests/qemu-iotests/086                  |  2 +-
 tests/qemu-iotests/087                  |  2 +-
 tests/qemu-iotests/088                  |  2 +-
 tests/qemu-iotests/089                  |  2 +-
 tests/qemu-iotests/090                  |  2 +-
 tests/qemu-iotests/091                  |  2 +-
 tests/qemu-iotests/092                  |  2 +-
 tests/qemu-iotests/094                  |  2 +-
 tests/qemu-iotests/095                  |  2 +-
 tests/qemu-iotests/097                  |  2 +-
 tests/qemu-iotests/098                  |  2 +-
 tests/qemu-iotests/099                  |  2 +-
 tests/qemu-iotests/101                  |  2 +-
 tests/qemu-iotests/102                  |  2 +-
 tests/qemu-iotests/103                  |  2 +-
 tests/qemu-iotests/104                  |  2 +-
 tests/qemu-iotests/105                  |  2 +-
 tests/qemu-iotests/106                  |  2 +-
 tests/qemu-iotests/107                  |  2 +-
 tests/qemu-iotests/108                  |  2 +-
 tests/qemu-iotests/109                  |  2 +-
 tests/qemu-iotests/110                  |  2 +-
 tests/qemu-iotests/111                  |  2 +-
 tests/qemu-iotests/112                  |  2 +-
 tests/qemu-iotests/113                  |  2 +-
 tests/qemu-iotests/114                  |  2 +-
 tests/qemu-iotests/115                  |  2 +-
 tests/qemu-iotests/116                  |  2 +-
 tests/qemu-iotests/117                  |  2 +-
 tests/qemu-iotests/119                  |  2 +-
 tests/qemu-iotests/120                  |  2 +-
 tests/qemu-iotests/121                  |  2 +-
 tests/qemu-iotests/122                  |  2 +-
 tests/qemu-iotests/123                  |  2 +-
 tests/qemu-iotests/125                  |  2 +-
 tests/qemu-iotests/126                  |  2 +-
 tests/qemu-iotests/127                  |  2 +-
 tests/qemu-iotests/128                  |  2 +-
 tests/qemu-iotests/130                  |  2 +-
 tests/qemu-iotests/131                  |  2 +-
 tests/qemu-iotests/133                  |  2 +-
 tests/qemu-iotests/134                  |  2 +-
 tests/qemu-iotests/135                  |  2 +-
 tests/qemu-iotests/137                  |  2 +-
 tests/qemu-iotests/138                  |  2 +-
 tests/qemu-iotests/140                  |  2 +-
 tests/qemu-iotests/141                  |  2 +-
 tests/qemu-iotests/142                  |  2 +-
 tests/qemu-iotests/143                  |  2 +-
 tests/qemu-iotests/144                  |  2 +-
 tests/qemu-iotests/145                  |  2 +-
 tests/qemu-iotests/146                  |  2 +-
 tests/qemu-iotests/150                  |  2 +-
 tests/qemu-iotests/153                  |  2 +-
 tests/qemu-iotests/154                  |  2 +-
 tests/qemu-iotests/156                  |  2 +-
 tests/qemu-iotests/157                  |  2 +-
 tests/qemu-iotests/158                  |  2 +-
 tests/qemu-iotests/159                  |  2 +-
 tests/qemu-iotests/160                  |  2 +-
 tests/qemu-iotests/161                  |  2 +-
 tests/qemu-iotests/162                  |  2 +-
 tests/qemu-iotests/170                  |  2 +-
 tests/qemu-iotests/171                  |  2 +-
 tests/qemu-iotests/172                  |  2 +-
 tests/qemu-iotests/173                  |  2 +-
 tests/qemu-iotests/174                  |  2 +-
 tests/qemu-iotests/175                  |  2 +-
 tests/qemu-iotests/176                  |  2 +-
 tests/qemu-iotests/177                  |  2 +-
 tests/qemu-iotests/178                  |  2 +-
 tests/qemu-iotests/179                  |  2 +-
 tests/qemu-iotests/181                  |  2 +-
 tests/qemu-iotests/182                  |  2 +-
 tests/qemu-iotests/183                  |  2 +-
 tests/qemu-iotests/184                  |  2 +-
 tests/qemu-iotests/185                  |  2 +-
 tests/qemu-iotests/186                  |  2 +-
 tests/qemu-iotests/187                  |  2 +-
 tests/qemu-iotests/188                  |  2 +-
 tests/qemu-iotests/189                  |  2 +-
 tests/qemu-iotests/190                  |  2 +-
 tests/qemu-iotests/191                  |  2 +-
 tests/qemu-iotests/192                  |  2 +-
 tests/qemu-iotests/195                  |  2 +-
 tests/qemu-iotests/197                  |  2 +-
 tests/qemu-iotests/198                  |  2 +-
 tests/qemu-iotests/200                  |  2 +-
 tests/qemu-iotests/201                  |  2 +-
 tests/qemu-iotests/204                  |  2 +-
 tests/qemu-iotests/214                  |  2 +-
 tests/qemu-iotests/215                  |  2 +-
 tests/qemu-iotests/217                  |  2 +-
 tests/qemu-iotests/220                  |  2 +-
 tests/qemu-iotests/221                  |  2 +-
 tests/qemu-iotests/223                  |  2 +-
 tests/qemu-iotests/225                  |  2 +-
 tests/qemu-iotests/226                  |  2 +-
 tests/qemu-iotests/227                  |  2 +-
 tests/qemu-iotests/229                  |  2 +-
 tests/qemu-iotests/231                  |  2 +-
 tests/qemu-iotests/232                  |  2 +-
 tests/qemu-iotests/233                  |  2 +-
 tests/qemu-iotests/check                |  2 +-
 tests/qemu-iotests/common.config        |  2 +-
 tests/qemu-iotests/common.filter        | 38 ++++++++++++-------------
 tests/qemu-iotests/common.nbd           |  2 +-
 tests/qemu-iotests/common.pattern       |  2 +-
 tests/qemu-iotests/common.qemu          |  2 +-
 tests/qemu-iotests/common.rc            | 15 +++++++++-
 tests/qemu-iotests/common.tls           |  2 +-
 187 files changed, 218 insertions(+), 205 deletions(-)

Comments

Thomas Huth March 7, 2019, 3:27 p.m. UTC | #1
On 07/03/2019 15.58, Philippe Mathieu-Daudé wrote:
> Hi Thomas,

? -----^

I could take the patch for tests/data/acpi/rebuild-expected-aml.sh
through the qtests tree (if Michael or Igor don't want to take it), but
the other patches are not related to qtests...

 Thomas
Kevin Wolf March 7, 2019, 3:41 p.m. UTC | #2
Am 07.03.2019 um 16:27 hat Thomas Huth geschrieben:
> On 07/03/2019 15.58, Philippe Mathieu-Daudé wrote:
> > Hi Thomas,
> 
> ? -----^
> 
> I could take the patch for tests/data/acpi/rebuild-expected-aml.sh
> through the qtests tree (if Michael or Igor don't want to take it), but
> the other patches are not related to qtests...

I can take them through my tree (two block patches, and multiboot is
effectively unmaintained and I've taken patches for it before). If you
post an Acked-by for the the ACPI one, I'll take the whole series (after
review, of course).

Kevin
Philippe Mathieu-Daudé March 7, 2019, 3:44 p.m. UTC | #3
On 3/7/19 4:27 PM, Thomas Huth wrote:
> On 07/03/2019 15.58, Philippe Mathieu-Daudé wrote:
>> Hi Thomas,
> 
> ? -----^
> 
> I could take the patch for tests/data/acpi/rebuild-expected-aml.sh
> through the qtests tree (if Michael or Igor don't want to take it), but
> the other patches are not related to qtests...

Oh I misread your tests/[qtest] MAINTAINERS entry, my bad!

Still I'm not sure what to do, it is a pain to split it again in 3
different v5 series.
It would have been way easier to have all the OpenBSD enter as a single
series. If we drop OpenBSD support in the next, these patches become
less relevant/important (until some weird OS like Haiku get in again),
so I'll wait to see what happens during the next dev cycle.

Thanks and sorry for sending that to you at first!

Phil.
Kevin Wolf March 7, 2019, 4:24 p.m. UTC | #4
Am 07.03.2019 um 15:58 hat Philippe Mathieu-Daudé geschrieben:
> This series contains few script cleanups which help to
> run tests on OpenBSD.
> Note, this is a split of the previous series, here restricted
> to tests/.

Thanks, applied to the block branch.

Kevin
Philippe Mathieu-Daudé March 7, 2019, 4:41 p.m. UTC | #5
On 3/7/19 5:24 PM, Kevin Wolf wrote:
> Am 07.03.2019 um 15:58 hat Philippe Mathieu-Daudé geschrieben:
>> This series contains few script cleanups which help to
>> run tests on OpenBSD.
>> Note, this is a split of the previous series, here restricted
>> to tests/.
> 
> Thanks, applied to the block branch.

Thanks Kevin!

Phil.
Michael S. Tsirkin March 8, 2019, 3:18 a.m. UTC | #6
On Thu, Mar 07, 2019 at 04:27:36PM +0100, Thomas Huth wrote:
> On 07/03/2019 15.58, Philippe Mathieu-Daudé wrote:
> > Hi Thomas,
> 
> ? -----^
> 
> I could take the patch for tests/data/acpi/rebuild-expected-aml.sh
> through the qtests tree (if Michael or Igor don't want to take it), but
> the other patches are not related to qtests...
> 
>  Thomas

You can pick it up, sure

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>