mbox series

[v3,0/2] OpenBSD: Let QEMU 4.0 be usable from OpenBSD 6.0 and onwards

Message ID 20190307142822.8531-1-philmd@redhat.com
Headers show
Series OpenBSD: Let QEMU 4.0 be usable from OpenBSD 6.0 and onwards | expand

Message

Philippe Mathieu-Daudé March 7, 2019, 2:28 p.m. UTC
Since OpenBSD 6.0, the W^X protection is enforced by default.
TCG is incompatible with this protection, to be able to use the
QEMU binary, this protection has to be disabled.
The OpenBSD ports seens to have downstream patches to be able to
use QEMU, but these patches were never upstreamed.
This series allow to run QEMU when built from the mainstream sources.

I salvaged the minimum patches required to be able to run OpenBSD
from a previous series, which aimed at running the QEMU QTest suite
on OpenBSD. Sadly it seems there is not much interest in having this
OS covered by tests (except by Peter Maydell).

v2: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg07513.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06676.html

Philippe Mathieu-Daudé (2):
  oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure
  configure: Disable W^X on OpenBSD

 configure          | 11 +++++++++++
 util/oslib-posix.c | 12 ++++++++++++
 2 files changed, 23 insertions(+)

Comments

Daniel P. Berrangé March 7, 2019, 2:57 p.m. UTC | #1
On Thu, Mar 07, 2019 at 03:28:20PM +0100, Philippe Mathieu-Daudé wrote:
> Since OpenBSD 6.0, the W^X protection is enforced by default.
> TCG is incompatible with this protection, to be able to use the
> QEMU binary, this protection has to be disabled.
> The OpenBSD ports seens to have downstream patches to be able to
> use QEMU, but these patches were never upstreamed.
> This series allow to run QEMU when built from the mainstream sources.
> 
> I salvaged the minimum patches required to be able to run OpenBSD
> from a previous series, which aimed at running the QEMU QTest suite
> on OpenBSD. Sadly it seems there is not much interest in having this
> OS covered by tests (except by Peter Maydell).

What were the blocking issues with getting the test fixes accepted in
previous postings ?  Was it simply no one interested in reviewing it
or actual review problems ?

With our increased interest in CI & push to drop build targets which
are not actively maintained, I'd question whether OpenBSD (or any
build target in the same situation) should continue to be supported
if the test suite hasn't worked for several releases in a row & not
enough people are willing to contribute to fix it.

Regards,
Daniel
Philippe Mathieu-Daudé March 7, 2019, 4 p.m. UTC | #2
On 3/7/19 3:57 PM, Daniel P. Berrangé wrote:
> On Thu, Mar 07, 2019 at 03:28:20PM +0100, Philippe Mathieu-Daudé wrote:
>> Since OpenBSD 6.0, the W^X protection is enforced by default.
>> TCG is incompatible with this protection, to be able to use the
>> QEMU binary, this protection has to be disabled.
>> The OpenBSD ports seens to have downstream patches to be able to
>> use QEMU, but these patches were never upstreamed.
>> This series allow to run QEMU when built from the mainstream sources.
>>
>> I salvaged the minimum patches required to be able to run OpenBSD
>> from a previous series, which aimed at running the QEMU QTest suite
>> on OpenBSD. Sadly it seems there is not much interest in having this
>> OS covered by tests (except by Peter Maydell).
> 
> What were the blocking issues with getting the test fixes accepted in
> previous postings ?  Was it simply no one interested in reviewing it
> or actual review problems ?
> 
> With our increased interest in CI & push to drop build targets which
> are not actively maintained, I'd question whether OpenBSD (or any
> build target in the same situation) should continue to be supported
> if the test suite hasn't worked for several releases in a row & not
> enough people are willing to contribute to fix it.

It is true nobody complained about this OS since the 6.0 release on
Sep 1, 2016, more than 2 years ago.

Looking at the mailing archive, Peter is the only one reporting build
failures since.
Paolo Bonzini March 7, 2019, 4:35 p.m. UTC | #3
On 07/03/19 15:28, Philippe Mathieu-Daudé wrote:
> Since OpenBSD 6.0, the W^X protection is enforced by default.
> TCG is incompatible with this protection, to be able to use the
> QEMU binary, this protection has to be disabled.
> The OpenBSD ports seens to have downstream patches to be able to
> use QEMU, but these patches were never upstreamed.
> This series allow to run QEMU when built from the mainstream sources.
> 
> I salvaged the minimum patches required to be able to run OpenBSD
> from a previous series, which aimed at running the QEMU QTest suite
> on OpenBSD. Sadly it seems there is not much interest in having this
> OS covered by tests (except by Peter Maydell).
> 
> v2: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg07513.html
> v1: https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06676.html
> 
> Philippe Mathieu-Daudé (2):
>   oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure
>   configure: Disable W^X on OpenBSD
> 
>  configure          | 11 +++++++++++
>  util/oslib-posix.c | 12 ++++++++++++
>  2 files changed, 23 insertions(+)
> 

Queued, thanks.

Paolo