From patchwork Wed Feb 27 14:06:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuval Shaia X-Patchwork-Id: 1048916 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=oracle.com header.i=@oracle.com header.b="UWvTO3qQ"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 448dGT36dZz9s21 for ; Thu, 28 Feb 2019 01:24:01 +1100 (AEDT) Received: from localhost ([127.0.0.1]:44764 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz07r-0003Yq-AS for incoming@patchwork.ozlabs.org; Wed, 27 Feb 2019 09:23:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyzrD-0007rN-OK for qemu-devel@nongnu.org; Wed, 27 Feb 2019 09:06:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyzrC-0003dB-TV for qemu-devel@nongnu.org; Wed, 27 Feb 2019 09:06:47 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:43340) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gyzrC-0003cU-Ew for qemu-devel@nongnu.org; Wed, 27 Feb 2019 09:06:46 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1RE3bVB098677; Wed, 27 Feb 2019 14:06:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id; s=corp-2018-07-02; bh=cSwoDf1R5d3oftI0zK3ZxQoHeUFky7HcpdhWqxdhg0U=; b=UWvTO3qQtedijfuv9P24EierJSzMVbo54QSmLwehHzEIYeXPJHxCkKUnhTWYSDFlOvMn cNSxrhB/+7bBmYaa44T9TOkRlGcPxUxODBNbd5461D8IPkohS1Q6RZPEIrrn6L6KGgKv mAJwxCDX4am8RvKwMAOh0w5QVP0k7AP+AmRiRwIyAdLmty2HP2tKhxLLZ4k9n/HQ6KOq y1PnAhYIR7T+DIXw8ej80OrZ/1/IwybvAxTmLwgclsCjMFhPv2gD8snq7fc/jCiA4oDr EiVQB2GimiW5CEzsX9du3mPrge4rHhTKCC4wtEcK/S09OJltTHOQmIC2FT8zE8Lwo6Nu Cw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2qtupeb7j3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Feb 2019 14:06:44 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1RE6gLd030118 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Feb 2019 14:06:43 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1RE6gG4011408; Wed, 27 Feb 2019 14:06:42 GMT Received: from localhost.localdomain (/77.138.186.148) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 27 Feb 2019 06:06:42 -0800 From: Yuval Shaia To: dgilbert@redhat.com, yuval.shaia@oracle.com, marcel.apfelbaum@gmail.com, armbru@redhat.com, qemu-devel@nongnu.org Date: Wed, 27 Feb 2019 16:06:20 +0200 Message-Id: <20190227140629.1569-1-yuval.shaia@oracle.com> X-Mailer: git-send-email 2.17.2 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9179 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902270095 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 141.146.126.79 Subject: [Qemu-devel] [PATCH v3 0/9] Misc fixes to pvrdma device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hi, Please review the following patch-set which consist of cosmetics fixes to device's user interface (traces, error_report and monitor) and some bug fixes. Thanks Markus, Eric, Marcel and David for reviewing v0. Appreciate your review to this v2. Still missing r-b for patches 2, 4 and 6. v0 -> v1: * Explain why device attributes are exposed only in HMP interface. * Squash the 3 patches related to HMP interface into one. * Make monitor dump function simple. * Make HMP interface available only if pvrdma is included (detected by build robot). * Remove patch 03/10 ("Warn when too many consecutive poll CQ triggered on an empty CQ) and add the two counters to patch 0/7 (monitor). * Add Marcel's R-Bs. * Add mutex protection to cqe_ctx list. * Add two new patches. v1 -> v2: * Rename locked-lists to protected-lists in patch 2 and patch 6. * Add Marcel's R-Bs. v2 -> v3: * Address some 32 bit host compilation issues Thanks, Yuval Yuval Shaia (9): hw/rdma: Switch to generic error reporting way hw/rdma: Introduce protected qlist hw/rdma: Protect against concurrent execution of poll_cq {monitor,hw/pvrdma}: Expose device internals via monitor interface hw/rdma: Free all MAD receive buffers when device is closed hw/rdma: Free all receive buffers when QP is destroyed hw/pvrdma: Delete unneeded function argument hw/pvrdma: Delete pvrdma_exit function hw/pvrdma: Unregister from shutdown notifier when device goes down hmp-commands-info.hx | 16 ++ hw/rdma/rdma_backend.c | 483 +++++++++++++++++----------------- hw/rdma/rdma_backend.h | 3 +- hw/rdma/rdma_backend_defs.h | 10 +- hw/rdma/rdma_rm.c | 140 +++++----- hw/rdma/rdma_rm.h | 6 +- hw/rdma/rdma_rm_defs.h | 28 +- hw/rdma/rdma_utils.c | 79 +++++- hw/rdma/rdma_utils.h | 61 ++--- hw/rdma/trace-events | 32 ++- hw/rdma/vmw/pvrdma.h | 7 +- hw/rdma/vmw/pvrdma_cmd.c | 113 ++------ hw/rdma/vmw/pvrdma_dev_ring.c | 26 +- hw/rdma/vmw/pvrdma_hmp.h | 21 ++ hw/rdma/vmw/pvrdma_main.c | 217 ++++++++------- hw/rdma/vmw/pvrdma_qp_ops.c | 52 +--- hw/rdma/vmw/trace-events | 16 +- monitor.c | 10 + 18 files changed, 715 insertions(+), 605 deletions(-) create mode 100644 hw/rdma/vmw/pvrdma_hmp.h