From patchwork Fri Dec 28 17:33:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1019223 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=208.118.235.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43RFNx70VLz9sBZ for ; Sat, 29 Dec 2018 05:20:00 +1100 (AEDT) Received: from localhost ([127.0.0.1]:60978 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcwjk-0000EK-GY for incoming@patchwork.ozlabs.org; Fri, 28 Dec 2018 13:19:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcwi9-0006zF-4w for qemu-devel@nongnu.org; Fri, 28 Dec 2018 13:18:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcwU9-0005VJ-26 for qemu-devel@nongnu.org; Fri, 28 Dec 2018 13:03:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58106) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gcw1Z-0001W7-1k for qemu-devel@nongnu.org; Fri, 28 Dec 2018 12:34:20 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 27C688667A; Fri, 28 Dec 2018 17:34:13 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-58.brq.redhat.com [10.40.204.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 109AC103BAB2; Fri, 28 Dec 2018 17:33:58 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Fri, 28 Dec 2018 18:33:51 +0100 Message-Id: <20181228173356.15359-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 28 Dec 2018 17:34:13 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v4 0/5] Fix strncpy() warnings for GCC8 new -Wstringop-truncation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Juan Quintela , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , David Hildenbrand , "Dr. David Alan Gilbert" , Markus Armbruster , =?utf-8?q?Marc-Andr=C3=A9_Lure?= =?utf-8?q?au?= , "Michael S. Tsirkin" , Igor Mammedov , Paolo Bonzini , David Gibson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" GCC 8 new warning prevents builds to success since quite some time. First report on the mailing list is in July 2018: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03723.html Since v3: - patch 1: make sens of description (eblake) - patch 2: append QEMU_NONSTRING instead of prepending it (mst) - patch 3: rebased (imammedo), intented - patch 4: replaced by Marc-André first attempt, improved doc - patch 5: add assert() and NUL-terminate the buffer (mst) Various intents has been sent to fix this: - Incorrectly using g_strlcpy() https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03705.html https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03706.html - Using assert() and strpadcpy() https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg03938.html This was the approch taken by the previous v2: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04405.html - Use #pragma GCC diagnostic ignored "-Wstringop-truncation" https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html - adding an inline wrapper with said pragma in there https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html - -Wno-stringop-truncation is the makefile https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04261.html - Use the 'nonstring' attribute https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04493.html This series add the QEMU_NONSTRING definition and use it. Regards, Phil. Marc-André Lureau (1): migration: Fix stringop-truncation warning Philippe Mathieu-Daudé (4): qemu/compiler: Define QEMU_NONSTRING block/sheepdog: Use QEMU_NONSTRING for non NUL-terminated arrays hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays migration: Use strnlen() for fixed-size string block/sheepdog.c | 2 +- hw/acpi/core.c | 12 ++++++++---- include/hw/acpi/acpi-defs.h | 13 ++++++++----- include/qemu/compiler.h | 15 +++++++++++++++ migration/global_state.c | 14 +++++++++++++- 5 files changed, 45 insertions(+), 11 deletions(-)