From patchwork Tue Apr 17 13:23:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Balamuruhan S X-Patchwork-Id: 899273 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40QQvx4mVdz9s0W for ; Tue, 17 Apr 2018 23:24:45 +1000 (AEST) Received: from localhost ([::1]:38605 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8QbD-0008B1-1A for incoming@patchwork.ozlabs.org; Tue, 17 Apr 2018 09:24:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8QaR-000876-Qt for qemu-devel@nongnu.org; Tue, 17 Apr 2018 09:24:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8QaO-0004B0-K2 for qemu-devel@nongnu.org; Tue, 17 Apr 2018 09:23:55 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:32784 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f8QaO-0004AI-F1 for qemu-devel@nongnu.org; Tue, 17 Apr 2018 09:23:52 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3HDIRwC014750 for ; Tue, 17 Apr 2018 09:23:49 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0b-001b2d01.pphosted.com with ESMTP id 2hdgkkux46-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Tue, 17 Apr 2018 09:23:48 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Apr 2018 14:23:44 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 17 Apr 2018 14:23:42 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3HDNfIM56557662; Tue, 17 Apr 2018 13:23:41 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4986B11C058; Tue, 17 Apr 2018 14:15:38 +0100 (BST) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 24F8811C050; Tue, 17 Apr 2018 14:15:37 +0100 (BST) Received: from 9.122.211.20 (unknown [9.122.211.20]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 17 Apr 2018 14:15:36 +0100 (BST) From: Balamuruhan S To: qemu-devel@nongnu.org Date: Tue, 17 Apr 2018 18:53:16 +0530 X-Mailer: git-send-email 2.14.3 X-TM-AS-GCONF: 00 x-cbid: 18041713-0020-0000-0000-00000412E56C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041713-0021-0000-0000-000042A725B1 Message-Id: <20180417132317.6910-1-bala24@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-04-17_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804170120 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.158.5 Subject: [Qemu-devel] [PATCH v2 0/1] migration: calculate expected_downtime with ram_bytes_remaining() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amit.shah@redhat.com, dgibson@redhat.com, Balamuruhan S , dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hi, v2: There is some difference in expected_downtime value due to following reason, 1. bandwidth and expected_downtime value are calculated in migration_update_counters() during each iteration from migration_thread() 2. remaining ram is calculated in qmp_query_migrate() when we actually call "info migrate" This v2 patch where bandwidth, expected_downtime and remaining ram are calculated in migration_update_counters(), retrieve the same value during "info migrate". By this approach we get almost close enough value, (qemu) info migrate globals: store-global-state: on only-migratable: off send-configuration: on send-section-footer: on capabilities: xbzrle: off rdma-pin-all: off auto-converge: off zero-blocks: off compress: off events: off postcopy-ram: off x-colo: off release-ram: off block: off return-path: off pause-before-switchover: off x-multifd: off dirty-bitmaps: off Migration status: active total time: 319737 milliseconds expected downtime: 1054 milliseconds setup: 16 milliseconds transferred ram: 3669862 kbytes throughput: 108.92 mbps remaining ram: 14016 kbytes total ram: 8388864 kbytes duplicate: 2296276 pages skipped: 0 pages normal: 910639 pages normal bytes: 3642556 kbytes dirty sync count: 249 page size: 4 kbytes dirty pages rate: 4626 pages Calculation: calculated value = (14016 * 8 ) / 108.92 = 1029.452809401 milliseconds actual value = 1054 milliseconds since v1: use ram_bytes_remaining() instead of dirty_pages_rate * page_size to calculate expected_downtime to be more accurate. Regards, Bala Balamuruhan S (1): migration: calculate expected_downtime with ram_bytes_remaining() migration/migration.c | 6 +++--- migration/migration.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-)