| Message ID | 20180321211056.3339-1-yuval.shaia@oracle.com |
|---|---|
| Headers | show |
| Series | hw/rdma: Fix 32-bit compilation | expand |
On 03/21/2018 04:10 PM, Yuval Shaia wrote: > Hi all, > Following are three patches which fixes various compilation warnings and > errors detected when compiling rdma device in 32bit host. > > All three patches are based on Eric Blake patch for rdma device. > Thanks! > > Patch #1: Change host_virt to void * > Low level IB verbs library accept void * argument so let's make sure this > is what we supply. This issue reported by Eric Blake. > > Patch #2: Use correct print format in CHK_ATTR macro > This macro can utilize the given 'format' argument and not need to cast all > members to u64. This patch is an alternative to suggested patch by Eric > Blake. > > Patch #3: Fix 32-bit compilation > Based on Eric Blake patch this patch replaces all %ld/%lx with the platform > independent PRIx64/PRId64 format. > > Again, thanks Eric Blake for the report. > > Yuval Shaia (3): > hw/rdma: Change host_virt to void * > hw/rdma: Use correct print format in CHK_ATTR macro Your fix was nicer than my proposal. > hw/rdma: Fix 32-bit compilation Reviewed-by: Eric Blake <eblake@redhat.com> and it fixes the build on my 32-bit rawhide VM, so Tested-by: Eric Blake <eblake@redhat.com>
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180321211056.3339-1-yuval.shaia@oracle.com
Subject: [Qemu-devel] [PATCH 0/3] hw/rdma: Fix 32-bit compilation
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7968402545 hw/rdma: Fix 32-bit compilation
3924e0635d hw/rdma: Use correct print format in CHK_ATTR macro
928edb0554 hw/rdma: Change host_virt to void *
=== OUTPUT BEGIN ===
Checking PATCH 1/3: hw/rdma: Change host_virt to void *...
Checking PATCH 2/3: hw/rdma: Use correct print format in CHK_ATTR macro...
Checking PATCH 3/3: hw/rdma: Fix 32-bit compilation...
WARNING: line over 80 characters
#40: FILE: hw/rdma/rdma_backend.c:180:
+ pr_dbg("ibv_create_ah failed for gid <0x%" PRIx64 ", 0x%" PRIx64 ">\n",
ERROR: space prohibited before that close parenthesis ')'
#78: FILE: hw/rdma/rdma_backend.c:673:
+ CHK_ATTR(dev_attr, backend_dev->dev_attr, max_mr_size, "%" PRId64 );
WARNING: line over 80 characters
#244: FILE: hw/rdma/vmw/pvrdma_main.c:345:
+ pr_err("Error trying to set REG value, addr=0x%" PRIx64 ", val=0x%" PRIx64 "\n",
total: 1 errors, 2 warnings, 248 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
Hi Yuval, ----- Original Message ----- > From: no-reply@patchew.org > To: "yuval shaia" <yuval.shaia@oracle.com> > Cc: famz@redhat.com, "yuval shaia" <yuval.shaia@oracle.com>, marcel@redhat.com, eblake@redhat.com, > qemu-devel@nongnu.org, qemu-trivial@nongnu.org > Sent: Thursday, March 22, 2018 7:07:35 AM > Subject: Re: [Qemu-devel] [PATCH 0/3] hw/rdma: Fix 32-bit compilation > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > [...] > === OUTPUT BEGIN === > Checking PATCH 1/3: hw/rdma: Change host_virt to void *... > Checking PATCH 2/3: hw/rdma: Use correct print format in CHK_ATTR macro... > Checking PATCH 3/3: hw/rdma: Fix 32-bit compilation... > WARNING: line over 80 characters > #40: FILE: hw/rdma/rdma_backend.c:180: > + pr_dbg("ibv_create_ah failed for gid <0x%" PRIx64 ", 0x%" PRIx64 > ">\n", > > ERROR: space prohibited before that close parenthesis ')' > #78: FILE: hw/rdma/rdma_backend.c:673: > + CHK_ATTR(dev_attr, backend_dev->dev_attr, max_mr_size, "%" PRId64 ); > > WARNING: line over 80 characters > #244: FILE: hw/rdma/vmw/pvrdma_main.c:345: > + pr_err("Error trying to set REG value, addr=0x%" PRIx64 ", val=0x%" > PRIx64 "\n", > > total: 1 errors, 2 warnings, 248 lines checked > Can you please fix and resend? Thanks, Marcel > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-devel@freelists.org