mbox series

[v2,0/2] ui/cocoa.m: enable guest to see control-alt key combinations

Message ID 20171005145557.5746-1-programmingkidx@gmail.com
Headers show
Series ui/cocoa.m: enable guest to see control-alt key combinations | expand

Message

Programmingkid Oct. 5, 2017, 2:55 p.m. UTC 
Currently if the user needs to send a control-alt key combination, he or she was either out of luck or had to rely on the monitor's sendkey command to do so. With this patch the user can now directly send control-alt key combinations. This is great for Windows guest that may need the control-alt-delete key combination. 

John Arbuckle (2):
  move ungrab to ctrl-alt-g
  send ctrl-alt key combinations to guest if not used by QEMU

 ui/cocoa.m | 34 ++++++++++++++++------------------
 1 file changed, 16 insertions(+), 18 deletions(-)

--
v2 changes:
- changed logic to use existing if case
 
2.13.5 (Apple Git-94)

Comments

no-reply@patchew.org Oct. 5, 2017, 4:39 p.m. UTC | #1 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20171005145557.5746-1-programmingkidx@gmail.com
Subject: [Qemu-devel] [PATCH v2 0/2] ui/cocoa.m: enable guest to see control-alt key combinations

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1506092407-26985-1-git-send-email-peter.maydell@linaro.org -> patchew/1506092407-26985-1-git-send-email-peter.maydell@linaro.org
 t [tag update]            patchew/20171005155057.7664-1-berrange@redhat.com -> patchew/20171005155057.7664-1-berrange@redhat.com
Switched to a new branch 'test'
16fa5de081 ui/cocoa.m: send ctrl-alt key combinations to guest if not used by QEMU
d71057fc7d ui/cocoa.m: move ungrab to ctrl-alt-g

=== OUTPUT BEGIN ===
Checking PATCH 1/2: ui/cocoa.m: move ungrab to ctrl-alt-g...
ERROR: The correct form is "Signed-off-by"
#8: 
signed-off-by: John Arbuckle <programmingkidx@gmail.com>

total: 1 errors, 0 warnings, 40 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: ui/cocoa.m: send ctrl-alt key combinations to guest if not used by QEMU...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org