From patchwork Thu Nov 29 02:12:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Mendoza-Jonas X-Patchwork-Id: 1004984 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4351PL223Wz9s3l for ; Thu, 29 Nov 2018 13:17:10 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="KHI6rqEc"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="SAxjNjEr"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4351PL01FmzDr1b for ; Thu, 29 Nov 2018 13:17:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="KHI6rqEc"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="SAxjNjEr"; dkim-atps=neutral X-Original-To: petitboot@lists.ozlabs.org Delivered-To: petitboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=mendozajonas.com (client-ip=66.111.4.28; helo=out4-smtp.messagingengine.com; envelope-from=sam@mendozajonas.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=mendozajonas.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="KHI6rqEc"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="SAxjNjEr"; dkim-atps=neutral Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4351Jg5hZ0zDqgV for ; Thu, 29 Nov 2018 13:13:07 +1100 (AEDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 1D27521AD0; Wed, 28 Nov 2018 21:13:05 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 28 Nov 2018 21:13:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= mendozajonas.com; h=from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; s=fm1; bh=AqnMQ3fAuIZBG TbKxHbYGu+icSfYHX8b/ANxczdrO9Q=; b=KHI6rqEcDTs+mQQOA0m9UvizfQXMq 0wkNFL+CnoEzSks6JcLZqyvDdluXWXt+4RiJNF+ZY4yZsgWH7a0QXX0cxtrIXi4e RfNn10ExItlWdnSgTegt2K8qgWfZG6vlr8qSEPByl7Z6cKShrIBs7NyBN0wyu5x5 CgXRfkc3u3Hc2V0maCZhgOH+12UHELOrqZ+vKY6r7o68z55W71i+HFsJVXW2r5U6 IjuVTY0qWiyVgg42kq+nrqY/KuEXoXcaGFfJSRIhTvUQnCMX+9K9If2677V7IPjC /vpFhsvjO7rYE9/I9d1CXVF84rK4JLlATzR/4VqNNxOPXR+SvT8Zq9r2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=AqnMQ3fAuIZBGTbKx HbYGu+icSfYHX8b/ANxczdrO9Q=; b=SAxjNjErhLj0Eym1FmGo1SCP7rGBydgZq tG/RCuOVJ9H5T9wQ31YchItRzwmbVbbkntwEZJnb+TQqmlXDDZdoVF1lw/EBc2WO +dps6fdWMO6O7SVqXQzCgfHgqXqhPD0OFPZBi4t680WErNjz1Y4EhyW/pRc3cevf RX5G6GgtbkabaYZuHsiWxOxyfm9mHj7Qsv1X5Ielu1LyqP6LaHmGjAYsI46tu8ud HKiPoVGFzRzjsNEM8oHA7Eeu8u/lMZyABRthpNTsPLdGvElw83bHt5VZGneZkCPY uD6LChsKl4HYV5DxmuFwFAxJ8PTGLwF5koWtM0cXrNbR3etLsD2Rg== X-ME-Sender: X-ME-Proxy: Received: from v4.ozlabs.ibm.com (unknown [122.99.82.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 984781040A; Wed, 28 Nov 2018 21:13:03 -0500 (EST) From: Samuel Mendoza-Jonas To: petitboot@lists.ozlabs.org Subject: [PATCH] discover: Display warning if saving config fails Date: Thu, 29 Nov 2018 13:12:55 +1100 Message-Id: <20181129021255.32632-1-sam@mendozajonas.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-BeenThere: petitboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Petitboot bootloader development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Mendoza-Jonas Errors-To: petitboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Petitboot" Signed-off-by: Samuel Mendoza-Jonas --- discover/device-handler.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/discover/device-handler.c b/discover/device-handler.c index 271b9880..729ed2c0 100644 --- a/discover/device-handler.c +++ b/discover/device-handler.c @@ -1501,8 +1501,11 @@ void device_handler_update_config(struct device_handler *handler, int rc; rc = config_set(config); - if (rc) + if (rc) { + device_handler_status_err(handler, + "Failed to update configuration!"); return; + } discover_server_notify_config(handler->server, config); device_handler_update_lang(config->lang);