From patchwork Tue Jan 24 04:52:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Mendoza-Jonas X-Patchwork-Id: 718885 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3v6wmK4CJLz9ryT for ; Tue, 24 Jan 2017 15:53:05 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="cN07iBks"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3v6wmK39mZzDqSM for ; Tue, 24 Jan 2017 15:53:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="cN07iBks"; dkim-atps=neutral X-Original-To: petitboot@lists.ozlabs.org Delivered-To: petitboot@lists.ozlabs.org Received: from mendozajonas.com (mendozajonas.com [188.166.185.233]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3v6wm96N7SzDqGw for ; Tue, 24 Jan 2017 15:52:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=mendozajonas.com header.i=@mendozajonas.com header.b="cN07iBks"; dkim-atps=neutral Received: from skellige.ozlabs.ibm.com (unknown [122.99.82.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: sam@mendozajonas.com) by mendozajonas.com (Postfix) with ESMTPSA id 51D47143FAE; Tue, 24 Jan 2017 12:52:54 +0800 (SGT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mendozajonas.com; s=mail; t=1485233574; bh=zfYRK7jHTuyLYNdpFbWSbrkAu9qkHjHBmKITE29Tgxo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cN07iBksSsUChIzCH7cndOLTSicuPP/UinavXab+ZeqwoN/urUhNw4QgBr3oUN5Gf J0TseBQBznpX+CG3FEFsVuD0WHQGnRfUSLl4N/S65Z/KRKWPKeDTI7s1Uri7Tf3htF eQeG3CmwWe0XUifTPq4eJRz+Jsy3ILzHKEr7rT1U= From: Samuel Mendoza-Jonas To: petitboot@lists.ozlabs.org Subject: [PATCH 2/2] process: Cancel all asynchronous jobs on reinit Date: Tue, 24 Jan 2017 15:52:48 +1100 Message-Id: <20170124045248.23804-2-sam@mendozajonas.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170124045248.23804-1-sam@mendozajonas.com> References: <20170124045248.23804-1-sam@mendozajonas.com> X-BeenThere: petitboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Petitboot bootloader development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Samuel Mendoza-Jonas MIME-Version: 1.0 Errors-To: petitboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Petitboot" If an asynchronous job is running over a reinit, the process can return and run its callback function after the reinit. This becomes a problem if the callback function accesses pointers that were only valid before the reinit (eg. device structs). If a reinit is requested explicitly stop all active asynchronous jobs and clear their callback functions before the reinit. Signed-off-by: Samuel Mendoza-Jonas --- discover/device-handler.c | 3 +++ lib/process/process.c | 21 +++++++++++++++++++++ lib/process/process.h | 2 ++ 3 files changed, 26 insertions(+) diff --git a/discover/device-handler.c b/discover/device-handler.c index a3e5bdb..dd8249f 100644 --- a/discover/device-handler.c +++ b/discover/device-handler.c @@ -358,6 +358,9 @@ void device_handler_reinit(struct device_handler *handler) handler->pending_boot_is_default = false; } + /* Cancel any remaining async jobs */ + process_stop_async_all(); + /* free unresolved boot options */ list_for_each_entry_safe(&handler->unresolved_boot_options, opt, tmp, list) diff --git a/lib/process/process.c b/lib/process/process.c index 93fd9c9..f7e5b8f 100644 --- a/lib/process/process.c +++ b/lib/process/process.c @@ -440,8 +440,29 @@ int process_run_async(struct process *process) void process_stop_async(struct process *process) { + /* Avoid signalling an old pid */ + if (process->cancelled) + return; + pb_debug("process: sending SIGTERM to pid %d\n", process->pid); kill(process->pid, SIGTERM); + process->cancelled = true; +} + +void process_stop_async_all(void) +{ + struct process_info *procinfo; + struct process *process = NULL; + + pb_debug("process: cancelling all async jobs\n"); + + list_for_each_entry(&procset->async_list, procinfo, async_list) { + process = &procinfo->process; + /* Ignore the process completion - callbacks may use stale data */ + process->exit_cb = NULL; + process->stdout_cb = NULL; + process_stop_async(process); + } } int process_run_simple_argv(void *ctx, const char *argv[]) diff --git a/lib/process/process.h b/lib/process/process.h index 65fdba8..f858b0e 100644 --- a/lib/process/process.h +++ b/lib/process/process.h @@ -45,6 +45,7 @@ struct process { /* post-execution information */ int exit_status; + bool cancelled; }; /* Process management system init. process_init must be called before @@ -77,6 +78,7 @@ int process_run_simple(void *ctx, const char *name, ...) int process_run_async(struct process *process); void process_stop_async(struct process *process); +void process_stop_async_all(void); /* helper function to determine if a process exited cleanly, with a non-zero * exit status */