mbox series

[v2,0/3] discover/grub: Some improvements and fixes for BLS support

Message ID 20180607173535.20629-1-javierm@redhat.com
Headers show
Series discover/grub: Some improvements and fixes for BLS support | expand

Message

Javier Martinez Canillas June 7, 2018, 5:35 p.m. UTC 
Hello,

This series contains some improvements and fixes for issues that I found
when doing more extensive testing of the Petitboot BLS support.

Patch #1 is just a small fix for the parser_scandir() stub function used
in the test harness.

Patch #2 allows BLS snippets to not only be in a /boot partition but also
in the root partition if /boot isn't a mount point. This configuration is
already supported by the grub.cfg file but I missed for BLS files.

Patch #3 improves the environment variables evaluation for BLS files, to
be in par of what's supported by the grub.cfg file.

Changes since v1:
- Don't propagate errors when expanding env vars since these may not be defined.

Best regards,
Javier


Javier Martinez Canillas (3):
  test/parser: Make parser_scandir() ignore files with path len less
    than dir
  discover/grub: Use different paths to search for the BLS directory
  discover/grub: Improve BLS grub environment variables expansion

 discover/grub2/blscfg.c                       | 108 +++++++++++++++---
 .../test-grub2-blscfg-default-filename.c      |   8 +-
 test/parser/test-grub2-blscfg-default-index.c |  14 ++-
 test/parser/test-grub2-blscfg-default-title.c |   8 +-
 test/parser/test-grub2-blscfg-multiple-bls.c  |   7 +-
 test/parser/test-grub2-blscfg-opts-config.c   |   2 +
 test/parser/test-grub2-blscfg-opts-grubenv.c  |   6 +-
 test/parser/utils.c                           |   3 +
 8 files changed, 121 insertions(+), 35 deletions(-)