From patchwork Wed Apr 20 06:49:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1619352 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=L4w6zjRW; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KjrtR2R1Jz9sG0 for ; Wed, 20 Apr 2022 16:51:27 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KjrtR1f37z2ymb for ; Wed, 20 Apr 2022 16:51:27 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=L4w6zjRW; dkim-atps=neutral X-Original-To: pdbg@lists.ozlabs.org Delivered-To: pdbg@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::433; helo=mail-pf1-x433.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=L4w6zjRW; dkim-atps=neutral Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KjrtP1Cwyz2yn1 for ; Wed, 20 Apr 2022 16:51:25 +1000 (AEST) Received: by mail-pf1-x433.google.com with SMTP id n22so1143921pfa.0 for ; Tue, 19 Apr 2022 23:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nAlwd5K2WMbOHIhQby1lFykLL3PUhgVgvg4Dc5cXix0=; b=L4w6zjRW64tE698T44QwN+TOB2a5Otk8t+uZ+fA6WZc7haxhL7+8N4kSLeoHyoIfw4 ILx+dnbVd6IgYmC/2ZQC1LwDL6CyepPXAne7uZSM/fwxxcFzwv0/Yx7iKprmoDI/JNzo cFPIRlg69tl0Pd6OnfL9E6m6EHzxhPm+NUTfPaf9OKFnbX+i6RC+5WXS33M+1OkkjfLA RT+AD8WHSR+jOyKanmEaLq3QkNkyUpV6RhU8xTEBAMhIi+Q0R8DuIz91U3smFmpmCH99 hJv4pb0zmtpVmIsT6lAdXfNp8lXsOnqbpB0tDUFEMR5CHt+RkzodlxCiYibzzW9kRAVu gDXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nAlwd5K2WMbOHIhQby1lFykLL3PUhgVgvg4Dc5cXix0=; b=5VVsJiV9nmXpYSvWlLpJSTtEl4d73N/PxX2Drah+DKCjDNUdP7QAUx41CyUKn2ZGCm u+NmiA6THfAwTGCEvJrLXtImXWtRzmuh8ER6QEjObkDc/Z1dtUYzzUyM65tyocUFDHJe oIJMJvYvWhZam7T1qgmL9uvfGvdwl9KRNjwnemadoSXpdoA5lcRuQy8Ou5m85ExFWLF3 o4xnz7j3vaSlEXbpziSpw39CLER86NJQYOKp2yaR3FEozQCvIsR0NW0Yf0NqA/q6rl0H ST3sllEq2UYA6oqqGf7xBqUEVXU6Ju3TEv4rDFz8/CnknYFC/+oEI5NFMdXihw9sbpIg e99w== X-Gm-Message-State: AOAM531SU29qWwmVPQCRYKb/FZt7/TUunsorHUAcrm47QgsR1v0bcvXw JjryPlgWoxpzNfNZr8rjE/erRHg3j8YQdQ== X-Google-Smtp-Source: ABdhPJzMQsPyJEb7FL12jZQnH0LoGf54hfrvPdFtr6ALzSmvTdNhsYOXM+3EC0y3y9K8F1mfmqesbQ== X-Received: by 2002:a63:4d64:0:b0:39d:5e6e:242d with SMTP id n36-20020a634d64000000b0039d5e6e242dmr18083513pgl.32.1650437483372; Tue, 19 Apr 2022 23:51:23 -0700 (PDT) Received: from bobo.ozlabs.ibm.com ([203.221.203.144]) by smtp.gmail.com with ESMTPSA id x20-20020aa79574000000b005061f4782c5sm18481235pfq.183.2022.04.19.23.51.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 23:51:23 -0700 (PDT) From: Nicholas Piggin To: pdbg@lists.ozlabs.org Date: Wed, 20 Apr 2022 16:49:59 +1000 Message-Id: <20220420065013.222816-26-npiggin@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220420065013.222816-1-npiggin@gmail.com> References: <20220420065013.222816-1-npiggin@gmail.com> MIME-Version: 1.0 Subject: [Pdbg] [PATCH v2 25/39] gdbserver: return more registers X-BeenThere: pdbg@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "mailing list for https://github.com/open-power/pdbg development" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicholas Piggin Errors-To: pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Pdbg" Returning all default registers prevents the client from re-requesting them every time you run `info r`. Signed-off-by: Nicholas Piggin Reviewed-by: Joel Stanley --- src/pdbgproxy.c | 46 ++++++++++++++++++++++++++++++++-------------- 1 file changed, 32 insertions(+), 14 deletions(-) diff --git a/src/pdbgproxy.c b/src/pdbgproxy.c index ef8aa479..393b37bf 100644 --- a/src/pdbgproxy.c +++ b/src/pdbgproxy.c @@ -183,10 +183,10 @@ static void get_spr(uint64_t *stack, void *priv) { char data[REG_DATA_SIZE]; uint64_t value; + uint32_t value32; switch (stack[0]) { case 0x40: - /* Get PC/NIA */ if (thread_getnia(thread_target, &value)) PR_ERROR("Error reading NIA\n"); snprintf(data, REG_DATA_SIZE, "%016" PRIx64 , be64toh(value)); @@ -194,7 +194,6 @@ static void get_spr(uint64_t *stack, void *priv) break; case 0x41: - /* Get MSR */ if (thread_getmsr(thread_target, &value)) PR_ERROR("Error reading MSR\n"); snprintf(data, REG_DATA_SIZE, "%016" PRIx64 , be64toh(value)); @@ -202,35 +201,54 @@ static void get_spr(uint64_t *stack, void *priv) break; case 0x42: - /* Get CR */ - if (thread_getcr(thread_target, (uint32_t *)&value)) + if (thread_getcr(thread_target, &value32)) PR_ERROR("Error reading CR \n"); - snprintf(data, REG_DATA_SIZE, "%016" PRIx64 , be64toh(value)); + snprintf(data, REG_DATA_SIZE, "%016" PRIx64 , be64toh((uint64_t)value32)); send_response(fd, data); break; case 0x43: - /* Get LR */ - if (thread_getspr(thread_target, 8, &value)) + if (thread_getspr(thread_target, SPR_LR, &value)) PR_ERROR("Error reading LR\n"); snprintf(data, REG_DATA_SIZE, "%016" PRIx64 , be64toh(value)); send_response(fd, data); break; case 0x44: - /* Get CTR */ - if (thread_getspr(thread_target, 9, &value)) + if (thread_getspr(thread_target, SPR_CTR, &value)) PR_ERROR("Error reading CTR\n"); snprintf(data, REG_DATA_SIZE, "%016" PRIx64 , be64toh(value)); send_response(fd, data); break; case 0x45: - /* We can't get the whole XER register in RAM mode as part of it - * is in latches that we need to stop the clocks to get. Probably - * not helpful to only return part of a register in a debugger so - * return unavailable. */ - send_response(fd, "xxxxxxxxxxxxxxxx"); + /* + * Not all XER register bits may be recoverable with RAM + * mode accesses, so this may be not entirely accurate. + */ + if (thread_getspr(thread_target, SPR_XER, &value)) + PR_ERROR("Error reading XER\n"); + snprintf(data, REG_DATA_SIZE, "%016" PRIx64 , be64toh(value)); + send_response(fd, data); + break; + + case 0x46: + if (thread_getspr(thread_target, SPR_FPSCR, &value)) + PR_ERROR("Error reading FPSCR\n"); + snprintf(data, REG_DATA_SIZE, "%016" PRIx64 , be64toh(value)); + send_response(fd, data); + break; + case 0x67: + if (thread_getspr(thread_target, SPR_VSCR, &value)) + PR_ERROR("Error reading VSCR\n"); + snprintf(data, REG_DATA_SIZE, "%016" PRIx64 , be64toh(value)); + send_response(fd, data); + break; + case 0x68: + if (thread_getspr(thread_target, SPR_VRSAVE, &value)) + PR_ERROR("Error reading VRSAVE\n"); + snprintf(data, REG_DATA_SIZE, "%016" PRIx64 , be64toh(value)); + send_response(fd, data); break; default: