From patchwork Wed Apr 20 06:49:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1619339 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=qG1SkOyX; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Kjrst6lK5z9sG0 for ; Wed, 20 Apr 2022 16:50:58 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Kjrst62Wcz2ymS for ; Wed, 20 Apr 2022 16:50:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=qG1SkOyX; dkim-atps=neutral X-Original-To: pdbg@lists.ozlabs.org Delivered-To: pdbg@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::433; helo=mail-pf1-x433.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=qG1SkOyX; dkim-atps=neutral Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Kjrss0P9mz2ywH for ; Wed, 20 Apr 2022 16:50:56 +1000 (AEST) Received: by mail-pf1-x433.google.com with SMTP id x80so1118350pfc.1 for ; Tue, 19 Apr 2022 23:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BB/6NhHPJ574YxrSH8MTeH40Pvcu1XeN7aKNdYuD94g=; b=qG1SkOyX2k/B6O7X0heTcalscQnyeXvUyqMbKLIV5TW05tPHKwwbNSX7PzJYhhmE6b G6GEZXr/pn4bY8rMS5Q390Sxy5B/3rfG3Etvf/30QpwsLNfRyYQkcBycK41drGEmeF4/ jEOARSkt8hlMXI0MvVi1PQnKhPw7lrt6qKPzdg4SV1lFT/622N2EJ16GTSWsFTJIqskL KybqZBExjIV7zCTwMTTAIG2z9aTfpyiSTcJ/L18vQv/gvDuIsehc4OykpJy68Q5ACfJw XjAwlaj/d1rQgKbRdAUvg1KJh5MPIXfmthTzE4AivYz/bgQbSckVFpLtMLG4peDoczdh XZvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BB/6NhHPJ574YxrSH8MTeH40Pvcu1XeN7aKNdYuD94g=; b=PUzEhyOSCqPujn86CYjDAxLy++Sma7ux9+4s4JdHLmMOkhSw16duj0HQMaboln45ca XtAbu5kyR+yhY/ExakKBEmPcV56HaObu6ku9wo2ZEjBf4pYtW0dk9+JKyMA+ejObW0WE u2It5eN34MUWNErseUfh2LtSG8NVv7K2hBNJj2PLrtUZFR2C/08+Yf1M8FVNS7OVM+xR rsaqTaKrs9yaDrMYnvo7UhJifOI2pIGC9aCRQiC1qPyq57LB2GxDUeps6pVVWqaWcm0p ic/w6m5IXbvkX5zl7UxvaFFRpxeawuQRN5rPgDN9i7C5gsFcUuiTX8iYap3EgM+y7Kpi dOyQ== X-Gm-Message-State: AOAM532BtiuxMiWKf3suRrfrfBSJUysJ8PnxKNlr0+rFaR3bO8PwZaHW e+DtKcwm+YTD/j40ZSFKqC8FfCbtTaCaRw== X-Google-Smtp-Source: ABdhPJykPG4QrJ6HVG+r1ka7960joh7HWizsmr1PoXSoY/SReedGACRbvwSMmBnTiZTGbBz+4QYflA== X-Received: by 2002:a65:4947:0:b0:3a4:dd71:be90 with SMTP id q7-20020a654947000000b003a4dd71be90mr16957987pgs.449.1650437454815; Tue, 19 Apr 2022 23:50:54 -0700 (PDT) Received: from bobo.ozlabs.ibm.com ([203.221.203.144]) by smtp.gmail.com with ESMTPSA id x20-20020aa79574000000b005061f4782c5sm18481235pfq.183.2022.04.19.23.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 23:50:54 -0700 (PDT) From: Nicholas Piggin To: pdbg@lists.ozlabs.org Date: Wed, 20 Apr 2022 16:49:47 +1000 Message-Id: <20220420065013.222816-14-npiggin@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220420065013.222816-1-npiggin@gmail.com> References: <20220420065013.222816-1-npiggin@gmail.com> MIME-Version: 1.0 Subject: [Pdbg] [PATCH v2 13/39] libpdbg: thread_regs don't print regs X-BeenThere: pdbg@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "mailing list for https://github.com/open-power/pdbg development" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicholas Piggin Errors-To: pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Pdbg" The gdbserver uses thread_getregs to send data to the client, printing to console is noisy. Push the printing into callers that want it. Reviewed-by: Joel Stanley Signed-off-by: Nicholas Piggin --- libpdbg/chip.c | 2 -- libpdbg/thread.c | 7 +------ src/thread.c | 2 ++ 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/libpdbg/chip.c b/libpdbg/chip.c index 79aeb359..6cbf48b0 100644 --- a/libpdbg/chip.c +++ b/libpdbg/chip.c @@ -380,8 +380,6 @@ int ram_getregs(struct thread *thread, struct thread_regs *regs) CHECK_ERR(thread->ram_destroy(thread)); - thread_print_regs(regs); - return 0; } diff --git a/libpdbg/thread.c b/libpdbg/thread.c index 4a7523c0..78a59b8b 100644 --- a/libpdbg/thread.c +++ b/libpdbg/thread.c @@ -371,7 +371,6 @@ void thread_print_regs(struct thread_regs *regs) int thread_getregs(struct pdbg_target *target, struct thread_regs *regs) { struct thread *thread; - int err; assert(pdbg_target_is_class(target, "thread")); @@ -385,11 +384,7 @@ int thread_getregs(struct pdbg_target *target, struct thread_regs *regs) return -1; } - err = thread->getregs(thread, regs); - if (!err) - thread_print_regs(regs); - - return err; + return thread->getregs(thread, regs); } int thread_getgpr(struct pdbg_target *target, int gpr, uint64_t *value) diff --git a/src/thread.c b/src/thread.c index 8ddf4aeb..76909d67 100644 --- a/src/thread.c +++ b/src/thread.c @@ -362,6 +362,8 @@ static int thread_regs_print(struct reg_flags flags) if (thread_getregs(thread, ®s)) continue; + thread_print_regs(®s); + if (flags.do_backtrace) { struct pdbg_target *adu;