From patchwork Tue Mar 29 15:49:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1610690 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Qhp7+j95; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KSYt25Zskz9sFk for ; Wed, 30 Mar 2022 02:50:02 +1100 (AEDT) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KSYt24R2hz2yMK for ; Wed, 30 Mar 2022 02:50:02 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Qhp7+j95; dkim-atps=neutral X-Original-To: pdbg@lists.ozlabs.org Delivered-To: pdbg@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::62e; helo=mail-pl1-x62e.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Qhp7+j95; dkim-atps=neutral Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KSYt03gYpz2xYG for ; Wed, 30 Mar 2022 02:50:00 +1100 (AEDT) Received: by mail-pl1-x62e.google.com with SMTP id n18so17988730plg.5 for ; Tue, 29 Mar 2022 08:50:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rFsFUBiix5V2jhgKSIfZqDP+GQGBrg59SzIQLk0qU4o=; b=Qhp7+j95X/t53/7ICxOCHjMkEJkBMCU1fTXO5/lO2VYlstAJfYVD/FVK57jNLlXIqF b3Dg9kVjqQPqhkE1FYSXzSOrwBsHBx5lCZ0ihrEHXycGSOgSpn4X2I4Zy9ONeRO1LfHd 7OuogvclI5qTf72GlHt5JdrMDba7k2BCA9//ZqYmUzlz70Kyj2H+NOc3i+b0vBc+Lzx2 w76yyBnATmsG7qdQvNsnZitoq2PnZS2HFg9yRHrJZSQfZuFGyI2Rp3ItnXIU24jvbKuh X1wzYW+v9CUQfjvhoQEG5tnb1pjmnIlRRFIcq593FFwzLlRPblxzUpx/O/XvGYWCbMx+ snBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rFsFUBiix5V2jhgKSIfZqDP+GQGBrg59SzIQLk0qU4o=; b=V+2VKz5SHsd07eyZMBKlK6fBvhP8wBMYpl0QsIrhkjpyxsFgxBalJIdbnR8A8hLNoc 0MLAJB3dCOWrCE87bCrlKvY0WX7R0uFaDX5oT3xAQIhAb+HfLxQwqqCcBwzyddOGbZwl OLsCuvlv2XMPR5TJHYwbNd1Q6pPyyxb12lQm9AwEFozEsevKwFpj2i9eUrTUWv92614J HNBb86TeVN1x4lBdbCWk5P1paYSb/HL4QAGqFNh+RCKcifyOQMtjAV3M4oEgMcrVCamq YcHI9qXGqS6VXI5rS/mssBNPRtFWDrVxB3UX+q9KtSqCy7+3/FDyE1AC2kVeYq1eCxww 8irA== X-Gm-Message-State: AOAM533cdZeF685cW15D0bipynbLYkFrI9fJzH6y4vS3QjCL7JM8HFw+ y2hyhq4Z7NDLV6IEoDAZLG9wYdCOaTk= X-Google-Smtp-Source: ABdhPJyx33QD3ldaZ03sQy5SA+sAfyYvDKutUOXMAQYVPlFUdRDoFuwPvbTj5CCWqkRZnN6GmvZDxw== X-Received: by 2002:a17:902:ca13:b0:155:cea6:65b3 with SMTP id w19-20020a170902ca1300b00155cea665b3mr25181783pld.144.1648568998263; Tue, 29 Mar 2022 08:49:58 -0700 (PDT) Received: from bobo.ibm.com (58-6-255-110.tpgi.com.au. [58.6.255.110]) by smtp.gmail.com with ESMTPSA id s35-20020a056a001c6300b004fb20b5d6c1sm14163564pfw.40.2022.03.29.08.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Mar 2022 08:49:57 -0700 (PDT) From: Nicholas Piggin To: pdbg@lists.ozlabs.org Date: Wed, 30 Mar 2022 01:49:01 +1000 Message-Id: <20220329154931.493851-9-npiggin@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220329154931.493851-1-npiggin@gmail.com> References: <20220329154931.493851-1-npiggin@gmail.com> MIME-Version: 1.0 Subject: [Pdbg] [PATCH v2 08/38] gdbserver: use standard compatibility test calls X-BeenThere: pdbg@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "mailing list for https://github.com/open-power/pdbg development" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicholas Piggin Errors-To: pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Pdbg" p10.dts.m4 defines compatible = "ibm,power-thread", "ibm,power10-thread" which fails to match on a basic strcmp. Aside, find_driver in hwunit.c looks like the only other place that does a strcmp on compatible. I wonder if that should be changed as well? Signed-off-by: Nicholas Piggin --- src/pdbgproxy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pdbgproxy.c b/src/pdbgproxy.c index 5a8b5f9..906ed2f 100644 --- a/src/pdbgproxy.c +++ b/src/pdbgproxy.c @@ -532,8 +532,8 @@ static int gdbserver(uint16_t port) // // Temporary until I can get this working a bit smoother on p9 - if (strcmp(thread->compatible, "ibm,power8-thread")) { - PR_ERROR("GDBSERVER is only tested on POWER8\n"); + if (!pdbg_target_compatible(thread, "ibm,power8-thread")) { + PR_ERROR("GDBSERVER is only available on POWER8\n"); return -1; }