From patchwork Tue Mar 29 15:49:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1610692 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Z2CXlW6K; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KSYt73VWJz9sFk for ; Wed, 30 Mar 2022 02:50:07 +1100 (AEDT) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KSYt731lyz2xBK for ; Wed, 30 Mar 2022 02:50:07 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Z2CXlW6K; dkim-atps=neutral X-Original-To: pdbg@lists.ozlabs.org Delivered-To: pdbg@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::62b; helo=mail-pl1-x62b.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=Z2CXlW6K; dkim-atps=neutral Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KSYt458zZz2xBK for ; Wed, 30 Mar 2022 02:50:04 +1100 (AEDT) Received: by mail-pl1-x62b.google.com with SMTP id i11so6715264plg.12 for ; Tue, 29 Mar 2022 08:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xANBNAGcezeme0LOA2ZQBIoH/LrUoKn7Lw5gNP0G1E8=; b=Z2CXlW6KXErk9iBq7hLqlutf/wQWInwGv7ECqPUTVV3ButmnVuC3KXhFVOnVSH5oiN H7IWamag0N8qy5m38M5KlKqalYmNJIk0QiPlmWZyQgV2Pe0l9/YPx//cYm9GqqpXfsRu OSciepAWrU95DFGkU1S27Nx02gBSz475QOFhXdssbqGK/WkDC+XIa2GRKacqd/NeteyO tLCLrfqh+Ti8DRRpEPsnIloIeeN1obNP3RVp/T83vgtzrqug16ny5/tnKeqLS2rpe07z fcIAqOHmQZZPQJxCje3HWTIfFDHAbzJ1dn/lQrUIgbUlumrBnBRRCB5HCqtE1x+z5RQ1 LgQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xANBNAGcezeme0LOA2ZQBIoH/LrUoKn7Lw5gNP0G1E8=; b=Yq7MVoO7S9EJkFCGtm/Yn4NBsdVVUXn1CUTnnP8IIMjoRcLT9sH9ICUjjGXmLTefIv w5MJNdyvbtBzN/lAxDy77Pw5WB8i8uQsArLExW6xzsPyuWH03SGk9ZYPO5xwe0wVLSLK nelKUrQ/sWSZo0iog9KPmM+7/4H8TsovHcj0M5jrY/2CsdfqPzHtzOhbkoNpTLFqErBM ieo/sgvkvoG9vYJmqHAQ8KTT/cdgwWCI5MECow66byOZJypWmEN3503Pi/SzR4mMkp3r 8cqQM+E9hWkpdD4Pd0S7Ggh51VEl/KUoqvv5IphjR5MnieKKA25EcC3By9/ZulOJ+0nn ycNg== X-Gm-Message-State: AOAM532k541K4hwh2pBgeOXjGSk5Fko5WN6z/9RRjMuBcQsFTlFx3bt9 yVWXESou5SGsPtI46MuQkzHbjd9CRzM= X-Google-Smtp-Source: ABdhPJwJNxJr1+x4S3tpj7+/DTjuams1VqaWyJvSSF7ExrcQUoK3fQiy31rqvqJU7KJAo77Pq+u+Aw== X-Received: by 2002:a17:902:ce08:b0:153:8d90:a109 with SMTP id k8-20020a170902ce0800b001538d90a109mr30681238plg.157.1648569002415; Tue, 29 Mar 2022 08:50:02 -0700 (PDT) Received: from bobo.ibm.com (58-6-255-110.tpgi.com.au. [58.6.255.110]) by smtp.gmail.com with ESMTPSA id s35-20020a056a001c6300b004fb20b5d6c1sm14163564pfw.40.2022.03.29.08.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Mar 2022 08:50:02 -0700 (PDT) From: Nicholas Piggin To: pdbg@lists.ozlabs.org Date: Wed, 30 Mar 2022 01:49:03 +1000 Message-Id: <20220329154931.493851-11-npiggin@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220329154931.493851-1-npiggin@gmail.com> References: <20220329154931.493851-1-npiggin@gmail.com> MIME-Version: 1.0 Subject: [Pdbg] [PATCH v2 10/38] gdbserver: reduce PR_INFO noise X-BeenThere: pdbg@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "mailing list for https://github.com/open-power/pdbg development" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicholas Piggin Errors-To: pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Pdbg" Printing the first byte of the received packet in hex on its own line is not very useful and clutters debug output. We print the full received packet anyway which is generally quite readable. Remove the first byte info line, and replace it with a debug line that contains the entire hex string as hex bytes. Signed-off-by: Nicholas Piggin --- src/pdbgproxy.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/pdbgproxy.c b/src/pdbgproxy.c index 4c6327f..9e5e7d8 100644 --- a/src/pdbgproxy.c +++ b/src/pdbgproxy.c @@ -396,9 +396,15 @@ static int read_from_client(int fd) PR_INFO("0 bytes\n"); return -1; } else { + int i; + buffer[nbytes] = '\0'; - PR_INFO("%x\n", buffer[0]); PR_INFO("Recv: %s\n", buffer); + pdbg_log(PDBG_DEBUG, " hex: "); + for (i = 0; i < nbytes; i++) + pdbg_log(PDBG_DEBUG, "%02x ", buffer[i]); + pdbg_log(PDBG_DEBUG, "\n"); + parse_buffer(buffer, nbytes, &fd); }