From patchwork Mon Mar 14 04:17:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1604896 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=f+bBrlUW; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KH3Dg6gxvz9sG2 for ; Mon, 14 Mar 2022 15:18:11 +1100 (AEDT) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KH3Dg5w1Kz30Gk for ; Mon, 14 Mar 2022 15:18:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=f+bBrlUW; dkim-atps=neutral X-Original-To: pdbg@lists.ozlabs.org Delivered-To: pdbg@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::1032; helo=mail-pj1-x1032.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=f+bBrlUW; dkim-atps=neutral Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KH3DV35qJz2yb9 for ; Mon, 14 Mar 2022 15:18:02 +1100 (AEDT) Received: by mail-pj1-x1032.google.com with SMTP id b8so13335301pjb.4 for ; Sun, 13 Mar 2022 21:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f/3ukqQO/LSJnygcSs8p1KISonirWpRlG/nvdfFpk3g=; b=f+bBrlUWowjPpUu1cbUyNtWnAZEfwLhMnvagiBlCeCEf+BYT2wLQg4WnXWcq6WoKmi FTajo4EbKDv4oDdC7Vfx43mGf7tL0Ciwc4m3H7tkHiKvtZU++lxjkuYDRnXd/FrUzAxI PEFSZx5wcYCTH5fL6em4Y/QXYEBbRrTKS4Unz7UHeVGtwPSAZKVhpy8jEsaGteL3oehf KqRppHkcTAJE8SoL2tlhSF0vgdN2T4CK5n6Xj3aAXEFTffFkPIQjgfrX+q7Q85Nlszdp ENkdK8ON4rRCirS9CFASxNhFl0tB96jxwt93WRv6YuGoh0Nqnsu8axs+2C5tKaBgY7sL rzbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f/3ukqQO/LSJnygcSs8p1KISonirWpRlG/nvdfFpk3g=; b=sNlAwuDhiNCsByXXyKwf9u6hO73kkeFXEuc1FKll6Apy65GBoVew06hrXvJ1rjmpiH HHT4YJZrHicZcXBpMAwVVjrTNIvjVK/hpwadFSHEhngaR1OBlMNefp3nOuivZsvnipKs YtK/mzJ+t1YXg6M+9ob95VIW/Ao5ZI1ictFJf1ehG1QOq8z8HQmI6dmeCxvZRL55m/Er pUlm/0wlVbko0Ao/7tB6pY1X7O7gtEmrwigd0JWGcis6FV5DFb62DYbnn2JMj6OaSZVC Z6QV/P8mhTJMXP/o7GVUzK8V1FUq0iLvUj16ykLnxaAr/s+JiRpsWzrJH3znhsY/aTLd HpvA== X-Gm-Message-State: AOAM530HBwp1tU0+CZPKC+uO5j1szLw+FgLy94hDOwqBB5E+wN++jJyK UJ/y/ZD1N9HGIf9XOJwGAOVZxxOIAHM= X-Google-Smtp-Source: ABdhPJz0dupmk6pDC8rMfisl2eeHv4E+GVbwg+4VQF/XO5+4HfCSAQzPEsF/bCcPZCE5HKrlJ0a+Og== X-Received: by 2002:a17:902:e890:b0:151:e9c1:6386 with SMTP id w16-20020a170902e89000b00151e9c16386mr21586886plg.40.1647231480232; Sun, 13 Mar 2022 21:18:00 -0700 (PDT) Received: from bobo.ibm.com (110-175-148-108.static.tpgi.com.au. [110.175.148.108]) by smtp.gmail.com with ESMTPSA id d16-20020a056a00245000b004f771b48736sm14283018pfj.194.2022.03.13.21.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Mar 2022 21:18:00 -0700 (PDT) From: Nicholas Piggin To: pdbg@lists.ozlabs.org Date: Mon, 14 Mar 2022 14:17:29 +1000 Message-Id: <20220314041735.542867-10-npiggin@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220314041735.542867-1-npiggin@gmail.com> References: <20220314041735.542867-1-npiggin@gmail.com> MIME-Version: 1.0 Subject: [Pdbg] [PATCH 08/14] libpdbg: thread_regs don't print regs X-BeenThere: pdbg@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "mailing list for https://github.com/open-power/pdbg development" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicholas Piggin Errors-To: pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Pdbg" The gdbserver uses thread_getregs to send data to the client, printing to console is noisy. Push the printing into callers that want it. Signed-off-by: Nicholas Piggin Reviewed-by: Joel Stanley --- libpdbg/chip.c | 2 -- libpdbg/thread.c | 7 +------ src/thread.c | 2 ++ 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/libpdbg/chip.c b/libpdbg/chip.c index 79aeb35..6cbf48b 100644 --- a/libpdbg/chip.c +++ b/libpdbg/chip.c @@ -380,8 +380,6 @@ int ram_getregs(struct thread *thread, struct thread_regs *regs) CHECK_ERR(thread->ram_destroy(thread)); - thread_print_regs(regs); - return 0; } diff --git a/libpdbg/thread.c b/libpdbg/thread.c index 4a7523c..78a59b8 100644 --- a/libpdbg/thread.c +++ b/libpdbg/thread.c @@ -371,7 +371,6 @@ void thread_print_regs(struct thread_regs *regs) int thread_getregs(struct pdbg_target *target, struct thread_regs *regs) { struct thread *thread; - int err; assert(pdbg_target_is_class(target, "thread")); @@ -385,11 +384,7 @@ int thread_getregs(struct pdbg_target *target, struct thread_regs *regs) return -1; } - err = thread->getregs(thread, regs); - if (!err) - thread_print_regs(regs); - - return err; + return thread->getregs(thread, regs); } int thread_getgpr(struct pdbg_target *target, int gpr, uint64_t *value) diff --git a/src/thread.c b/src/thread.c index 8ddf4ae..76909d6 100644 --- a/src/thread.c +++ b/src/thread.c @@ -362,6 +362,8 @@ static int thread_regs_print(struct reg_flags flags) if (thread_getregs(thread, ®s)) continue; + thread_print_regs(®s); + if (flags.do_backtrace) { struct pdbg_target *adu;