diff mbox series

[v2,2/2] libpdbg: Auto-detect using bmc_target() for SBEFIFO backend

Message ID 20200625062544.306406-2-amitay@ozlabs.org
State Superseded
Headers show
Series [v2,1/2] libpdbg: Refactor code to get chip id | expand

Commit Message

Amitay Isaacs June 25, 2020, 6:25 a.m. UTC 
Signed-off-by: Amitay Isaacs <amitay@ozlabs.org>
---
 libpdbg/dtb.c | 56 +++++++++++++++++++++++++++++++++++++--------------
 1 file changed, 41 insertions(+), 15 deletions(-)
diff mbox series

Patch

diff --git a/libpdbg/dtb.c b/libpdbg/dtb.c
index 3006cda..e66af94 100644
--- a/libpdbg/dtb.c
+++ b/libpdbg/dtb.c
@@ -255,6 +255,46 @@  static void bmc_target(struct pdbg_dtb *dtb)
 	}
 }
 
+static void sbefifo_target(struct pdbg_dtb *dtb)
+{
+	uint32_t chip_id;
+
+	if (pdbg_backend_option) {
+		if (!strcmp(pdbg_backend_option, "p9")) {
+			if (!dtb->backend.fdt)
+				dtb->backend.fdt = &_binary_bmc_sbefifo_dtb_o_start;
+			if (!dtb->system.fdt)
+				dtb->system.fdt = &_binary_p9_dtb_o_start;
+		} else {
+			pdbg_log(PDBG_ERROR, "Invalid system type %s\n", pdbg_backend_option);
+			pdbg_log(PDBG_ERROR, "Use 'p9'\n");
+		}
+
+		return;
+	}
+
+	chip_id = get_chipid();
+
+	switch(chip_id) {
+	case CHIP_ID_P9:
+	case CHIP_ID_P9P:
+		pdbg_log(PDBG_INFO, "Found a POWER9 OpenBMC based system\n");
+		if (!dtb->backend.fdt)
+			dtb->backend.fdt = &_binary_bmc_sbefifo_dtb_o_start;
+		if (!dtb->system.fdt)
+			dtb->system.fdt = &_binary_p9_dtb_o_start;
+		break;
+
+	case CHIP_ID_P8:
+	case CHIP_ID_P8P:
+		pdbg_log(PDBG_ERROR, "SBEFIFO backend not supported on POWER8/8+ OpenBMC based system\n");
+		break;
+
+	default:
+		pdbg_log(PDBG_ERROR, "Unrecognised Chip ID register 0x%08" PRIx32 "\n", chip_id);
+	}
+}
+
 /* Opens a dtb at the given path */
 static void mmap_dtb(const char *file, bool readonly, struct pdbg_mfile *mfile)
 {
@@ -425,21 +465,7 @@  struct pdbg_dtb *pdbg_default_dtb(void *system_fdt)
 		break;
 
 	case PDBG_BACKEND_SBEFIFO:
-		if (!pdbg_backend_option) {
-			pdbg_log(PDBG_ERROR, "No system type specified\n");
-			pdbg_log(PDBG_ERROR, "Use p9\n");
-			return NULL;
-		}
-
-		if (!strcmp(pdbg_backend_option, "p9")) {
-			if (!dtb->backend.fdt)
-				dtb->backend.fdt = &_binary_bmc_sbefifo_dtb_o_start;
-			if (!dtb->system.fdt)
-				dtb->system.fdt = &_binary_p9_dtb_o_start;
-		} else {
-			pdbg_log(PDBG_ERROR, "Invalid system type %s\n", pdbg_backend_option);
-			pdbg_log(PDBG_ERROR, "Use p9\n");
-		}
+		sbefifo_target(dtb);
 		break;
 
 	default: