diff mbox series

[1/2] libpdbg: Move chip id definitions to common header

Message ID 20200526051312.71133-1-amitay@ozlabs.org
State Accepted
Headers show
Series [1/2] libpdbg: Move chip id definitions to common header | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch warning Failed to apply on branch master (86851b290ac1771b9a6fb0d5238ebf459ea80a21)
snowpatch_ozlabs/apply_patch fail Failed to apply to any branch

Commit Message

Amitay Isaacs May 26, 2020, 5:13 a.m. UTC
Signed-off-by: Amitay Isaacs <amitay@ozlabs.org>
---
 libpdbg/dtb.c    | 5 -----
 libpdbg/target.h | 5 +++++
 2 files changed, 5 insertions(+), 5 deletions(-)

Comments

Alistair Popple June 15, 2020, 7:39 a.m. UTC | #1
Reviewed-by: Alistair Popple <alistair@popple.id.au>

On Tuesday, 26 May 2020 3:13:11 PM AEST Amitay Isaacs wrote:
> Signed-off-by: Amitay Isaacs <amitay@ozlabs.org>
> ---
>  libpdbg/dtb.c    | 5 -----
>  libpdbg/target.h | 5 +++++
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/libpdbg/dtb.c b/libpdbg/dtb.c
> index aad6a21..6d9b182 100644
> --- a/libpdbg/dtb.c
> +++ b/libpdbg/dtb.c
> @@ -52,11 +52,6 @@
>  #define AMI_BMC "/proc/ractrends/Helper/FwInfo"
>  #define XSCOM_BASE_PATH "/sys/kernel/debug/powerpc/scom"
>  
> -#define CHIP_ID_P8  0xea
> -#define CHIP_ID_P8P 0xd3
> -#define CHIP_ID_P9  0xd1
> -#define CHIP_ID_P9P 0xd9
> -
>  static enum pdbg_backend pdbg_backend = PDBG_DEFAULT_BACKEND;
>  static const char *pdbg_backend_option;
>  static struct pdbg_dtb pdbg_dtb = {
> diff --git a/libpdbg/target.h b/libpdbg/target.h
> index 7094b51..522a4dc 100644
> --- a/libpdbg/target.h
> +++ b/libpdbg/target.h
> @@ -24,6 +24,11 @@
>  #include "compiler.h"
>  #include "libpdbg.h"
>  
> +#define CHIP_ID_P8  0xea
> +#define CHIP_ID_P8P 0xd3
> +#define CHIP_ID_P9  0xd1
> +#define CHIP_ID_P9P 0xd9
> +
>  enum chip_type {CHIP_UNKNOWN, CHIP_P8, CHIP_P8NV, CHIP_P9};
>  
>  struct pdbg_target_class {
>
diff mbox series

Patch

diff --git a/libpdbg/dtb.c b/libpdbg/dtb.c
index aad6a21..6d9b182 100644
--- a/libpdbg/dtb.c
+++ b/libpdbg/dtb.c
@@ -52,11 +52,6 @@ 
 #define AMI_BMC "/proc/ractrends/Helper/FwInfo"
 #define XSCOM_BASE_PATH "/sys/kernel/debug/powerpc/scom"
 
-#define CHIP_ID_P8  0xea
-#define CHIP_ID_P8P 0xd3
-#define CHIP_ID_P9  0xd1
-#define CHIP_ID_P9P 0xd9
-
 static enum pdbg_backend pdbg_backend = PDBG_DEFAULT_BACKEND;
 static const char *pdbg_backend_option;
 static struct pdbg_dtb pdbg_dtb = {
diff --git a/libpdbg/target.h b/libpdbg/target.h
index 7094b51..522a4dc 100644
--- a/libpdbg/target.h
+++ b/libpdbg/target.h
@@ -24,6 +24,11 @@ 
 #include "compiler.h"
 #include "libpdbg.h"
 
+#define CHIP_ID_P8  0xea
+#define CHIP_ID_P8P 0xd3
+#define CHIP_ID_P9  0xd1
+#define CHIP_ID_P9P 0xd9
+
 enum chip_type {CHIP_UNKNOWN, CHIP_P8, CHIP_P8NV, CHIP_P9};
 
 struct pdbg_target_class {