| Message ID | 20200421041655.82856-9-amitay@ozlabs.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add sbefifo backend | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (6ae2ba655ca5e24b403a33bf15dff7261d3e7052) |
| snowpatch_ozlabs/build-multiarch | success | Test build-multiarch on branch master |
Reviewed-by: Alistair Popple <alistair@popple.id.au> On Tuesday, 21 April 2020 2:16:44 PM AEST Amitay Isaacs wrote: > When using multiple compatible strings, use the generic compatible > string first and specific later. > > Signed-off-by: Amitay Isaacs <amitay@ozlabs.org> > --- > libpdbg/chip.c | 2 +- > p8.dts.m4 | 2 +- > p9.dts | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libpdbg/chip.c b/libpdbg/chip.c > index b961e87..848a831 100644 > --- a/libpdbg/chip.c > +++ b/libpdbg/chip.c > @@ -670,7 +670,7 @@ int thread_getregs(struct pdbg_target *thread, struct > thread_regs *regs) static struct proc proc = { > .target = { > .name = "Processor Module", > - .compatible = "ibm,processor", > + .compatible = "ibm,power-proc", > .class = "proc", > }, > }; > diff --git a/p8.dts.m4 b/p8.dts.m4 > index a508e02..754987a 100644 > --- a/p8.dts.m4 > +++ b/p8.dts.m4 > @@ -1,7 +1,7 @@ > define(`PROC',` > define(`PROC_ID',`$1')dnl > proc$1 { > - compatible = "ibm,power8-proc", "ibm,processor"; > + compatible = "ibm,power-proc", "ibm,power8-proc"; > index = <$1>; > > fsi { > diff --git a/p9.dts b/p9.dts > index 2d3fed2..6620b54 100644 > --- a/p9.dts > +++ b/p9.dts > @@ -7,7 +7,7 @@ > }; > > proc0 { > - compatible = "ibm,power9-proc", "ibm,processor"; > + compatible = "ibm,power-proc", "ibm,power9-proc"; > index = < 0x00 >; > > fsi { > @@ -1723,7 +1723,7 @@ > }; > > proc1 { > - compatible = "ibm,power9-proc", "ibm,processor"; > + compatible = "ibm,power-proc", "ibm,power9-proc"; > index = < 0x01 >; > > fsi {
diff --git a/libpdbg/chip.c b/libpdbg/chip.c index b961e87..848a831 100644 --- a/libpdbg/chip.c +++ b/libpdbg/chip.c @@ -670,7 +670,7 @@ int thread_getregs(struct pdbg_target *thread, struct thread_regs *regs) static struct proc proc = { .target = { .name = "Processor Module", - .compatible = "ibm,processor", + .compatible = "ibm,power-proc", .class = "proc", }, }; diff --git a/p8.dts.m4 b/p8.dts.m4 index a508e02..754987a 100644 --- a/p8.dts.m4 +++ b/p8.dts.m4 @@ -1,7 +1,7 @@ define(`PROC',` define(`PROC_ID',`$1')dnl proc$1 { - compatible = "ibm,power8-proc", "ibm,processor"; + compatible = "ibm,power-proc", "ibm,power8-proc"; index = <$1>; fsi { diff --git a/p9.dts b/p9.dts index 2d3fed2..6620b54 100644 --- a/p9.dts +++ b/p9.dts @@ -7,7 +7,7 @@ }; proc0 { - compatible = "ibm,power9-proc", "ibm,processor"; + compatible = "ibm,power-proc", "ibm,power9-proc"; index = < 0x00 >; fsi { @@ -1723,7 +1723,7 @@ }; proc1 { - compatible = "ibm,power9-proc", "ibm,processor"; + compatible = "ibm,power-proc", "ibm,power9-proc"; index = < 0x01 >; fsi {
When using multiple compatible strings, use the generic compatible string first and specific later. Signed-off-by: Amitay Isaacs <amitay@ozlabs.org> --- libpdbg/chip.c | 2 +- p8.dts.m4 | 2 +- p9.dts | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-)