diff mbox series

p9.dts: Fix mcbist index

Message ID 20200409014929.30111-1-alistair@popple.id.au
State Accepted
Headers show
Series p9.dts: Fix mcbist index | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch warning Failed to apply on branch master (8b4611b5d8e7e2279fe4aa80c892fcfe10aa398d)
snowpatch_ozlabs/apply_patch fail Failed to apply to any branch

Commit Message

Alistair Popple April 9, 2020, 1:49 a.m. UTC
Commit 4bf5a1087f55 ("dts: Fix index for mcbist targets") fixed up the
mcbist indicies but had them reveresed on the second processor. The
tests were correctly updated and caught this problem.

Signed-off-by: Alistair Popple <alistair@popple.id.au>
---
 p9.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Amitay Isaacs April 9, 2020, 1:57 a.m. UTC | #1
Reviewed-by: Amitay Isaacs <amitay@ozlabs.org>

I can't believe I missed this when the test is failing. :-(

Amitay.

On Thu, 2020-04-09 at 11:49 +1000, Alistair Popple wrote:
> Commit 4bf5a1087f55 ("dts: Fix index for mcbist targets") fixed up
> the
> mcbist indicies but had them reveresed on the second processor. The
> tests were correctly updated and caught this problem.
> 
> Signed-off-by: Alistair Popple <alistair@popple.id.au>
> ---
>  p9.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/p9.dts b/p9.dts
> index f8cb88b..a292803 100644
> --- a/p9.dts
> +++ b/p9.dts
> @@ -1890,7 +1890,7 @@
>  
>  					mcbist {
>  						compatible =
> "ibm,power9-mcbist";
> -						index = < 0x01 >;
> +						index = < 0x00 >;
>  					};
>  				};
>  			};
> @@ -1929,7 +1929,7 @@
>  
>  					mcbist {
>  						compatible =
> "ibm,power9-mcbist";
> -						index = < 0x00 >;
> +						index = < 0x01 >;
>  					};
>  				};
>  			};
> -- 
> 2.20.1
> 

Amitay.
Alistair Popple April 9, 2020, 2:07 a.m. UTC | #2
On Thursday, 9 April 2020 11:57:09 AM AEST Amitay Isaacs wrote:
> Reviewed-by: Amitay Isaacs <amitay@ozlabs.org>
> 
> I can't believe I missed this when the test is failing. :-(

Can't believe I didn't run the tests before pushing :-(
 
> Amitay.
> 
> On Thu, 2020-04-09 at 11:49 +1000, Alistair Popple wrote:
> > Commit 4bf5a1087f55 ("dts: Fix index for mcbist targets") fixed up
> > the
> > mcbist indicies but had them reveresed on the second processor. The
> > tests were correctly updated and caught this problem.
> > 
> > Signed-off-by: Alistair Popple <alistair@popple.id.au>
> > ---
> > 
> >  p9.dts | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/p9.dts b/p9.dts
> > index f8cb88b..a292803 100644
> > --- a/p9.dts
> > +++ b/p9.dts
> > @@ -1890,7 +1890,7 @@
> > 
> >  					mcbist {
> >  					
> >  						compatible =
> > 
> > "ibm,power9-mcbist";
> > -						index = < 0x01 >;
> > +						index = < 0x00 >;
> > 
> >  					};
> >  				
> >  				};
> >  			
> >  			};
> > 
> > @@ -1929,7 +1929,7 @@
> > 
> >  					mcbist {
> >  					
> >  						compatible =
> > 
> > "ibm,power9-mcbist";
> > -						index = < 0x00 >;
> > +						index = < 0x01 >;
> > 
> >  					};
> >  				
> >  				};
> >  			
> >  			};
> 
> Amitay.
diff mbox series

Patch

diff --git a/p9.dts b/p9.dts
index f8cb88b..a292803 100644
--- a/p9.dts
+++ b/p9.dts
@@ -1890,7 +1890,7 @@ 
 
 					mcbist {
 						compatible = "ibm,power9-mcbist";
-						index = < 0x01 >;
+						index = < 0x00 >;
 					};
 				};
 			};
@@ -1929,7 +1929,7 @@ 
 
 					mcbist {
 						compatible = "ibm,power9-mcbist";
-						index = < 0x00 >;
+						index = < 0x01 >;
 					};
 				};
 			};