| Message ID | 20200115051901.17514-4-amitay@ozlabs.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Use fdt properties directly | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | warning | Failed to apply on branch master (8b4611b5d8e7e2279fe4aa80c892fcfe10aa398d) |
| snowpatch_ozlabs/apply_patch | fail | Failed to apply to any branch |
Thanks for fix up this hack. Reviewed-by: Alistair Popple <alistair@popple.id.au> On Wednesday, 15 January 2020 4:18:51 PM AEDT Amitay Isaacs wrote: > This reverts commit 376e498fb5a69afd5a2a0349bd3a37dd774a225e. > > Instead of exposing the internal structures, add an api to get system > device tree. > --- > libpdbg/libpdbg.h | 5 ----- > libpdbg/target.h | 6 ++++++ > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/libpdbg/libpdbg.h b/libpdbg/libpdbg.h > index 6fd16f3..4a8f1cf 100644 > --- a/libpdbg/libpdbg.h > +++ b/libpdbg/libpdbg.h > @@ -102,11 +102,6 @@ uint64_t pdbg_target_address(struct pdbg_target > *target, uint64_t *size); (index == 0 ? pdbg_target_address(target, size) : > assert(0)) > > /* Misc. */ > -struct pdbg_dtb { > - void *backend; > - void *system; > -}; > -void pdbg_default_dtb(struct pdbg_dtb *pdtb, void *system_fdt); > bool pdbg_targets_init(void *fdt); > void pdbg_target_probe_all(struct pdbg_target *parent); > enum pdbg_target_status pdbg_target_probe(struct pdbg_target *target); > diff --git a/libpdbg/target.h b/libpdbg/target.h > index 9e25a43..f068e8d 100644 > --- a/libpdbg/target.h > +++ b/libpdbg/target.h > @@ -55,6 +55,11 @@ struct pdbg_target { > struct pdbg_target *vnode; > }; > > +struct pdbg_dtb { > + void *backend; > + void *system; > +}; > + > struct pdbg_target *get_parent(struct pdbg_target *target, bool system); > struct pdbg_target *target_parent(const char *klass, struct pdbg_target > *target, bool system); struct pdbg_target *require_target_parent(const char > *klass, struct pdbg_target *target, bool system); @@ -66,6 +71,7 @@ bool > pdbg_target_is_class(struct pdbg_target *target, const char *class); extern > struct list_head empty_list; > extern struct list_head target_classes; > > +void pdbg_default_dtb(struct pdbg_dtb *pdtb, void *system_fdt); > const char *pdbg_get_backend_option(void); > > struct chipop *pib_to_chipop(struct pdbg_target *target);
diff --git a/libpdbg/libpdbg.h b/libpdbg/libpdbg.h index 6fd16f3..4a8f1cf 100644 --- a/libpdbg/libpdbg.h +++ b/libpdbg/libpdbg.h @@ -102,11 +102,6 @@ uint64_t pdbg_target_address(struct pdbg_target *target, uint64_t *size); (index == 0 ? pdbg_target_address(target, size) : assert(0)) /* Misc. */ -struct pdbg_dtb { - void *backend; - void *system; -}; -void pdbg_default_dtb(struct pdbg_dtb *pdtb, void *system_fdt); bool pdbg_targets_init(void *fdt); void pdbg_target_probe_all(struct pdbg_target *parent); enum pdbg_target_status pdbg_target_probe(struct pdbg_target *target); diff --git a/libpdbg/target.h b/libpdbg/target.h index 9e25a43..f068e8d 100644 --- a/libpdbg/target.h +++ b/libpdbg/target.h @@ -55,6 +55,11 @@ struct pdbg_target { struct pdbg_target *vnode; }; +struct pdbg_dtb { + void *backend; + void *system; +}; + struct pdbg_target *get_parent(struct pdbg_target *target, bool system); struct pdbg_target *target_parent(const char *klass, struct pdbg_target *target, bool system); struct pdbg_target *require_target_parent(const char *klass, struct pdbg_target *target, bool system); @@ -66,6 +71,7 @@ bool pdbg_target_is_class(struct pdbg_target *target, const char *class); extern struct list_head empty_list; extern struct list_head target_classes; +void pdbg_default_dtb(struct pdbg_dtb *pdtb, void *system_fdt); const char *pdbg_get_backend_option(void); struct chipop *pib_to_chipop(struct pdbg_target *target);