From patchwork Wed Jul 18 05:59:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Neuling X-Patchwork-Id: 945510 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41VmhG3mX9z9s3Z for ; Wed, 18 Jul 2018 15:59:58 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=neuling.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 41VmhG1gwdzF3Hw for ; Wed, 18 Jul 2018 15:59:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=neuling.org X-Original-To: pdbg@lists.ozlabs.org Delivered-To: pdbg@lists.ozlabs.org Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41Vmh654sDzF3Hb for ; Wed, 18 Jul 2018 15:59:50 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=neuling.org Received: from localhost.localdomain (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 41Vmh6264Kz9s3R; Wed, 18 Jul 2018 15:59:50 +1000 (AEST) Received: by localhost.localdomain (Postfix, from userid 1000) id 2B8D4EE78BF; Wed, 18 Jul 2018 15:59:50 +1000 (AEST) From: Michael Neuling To: alistair@popple.id.au Date: Wed, 18 Jul 2018 15:59:47 +1000 Message-Id: <20180718055948.7237-1-mikey@neuling.org> X-Mailer: git-send-email 2.17.1 Subject: [Pdbg] [PATCH v4 1/2] Revert "main: Select only the targets specified on cmdline" X-BeenThere: pdbg@lists.ozlabs.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "mailing list for https://github.com/open-power/pdbg development" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pdbg@lists.ozlabs.org, Amitay Isaacs MIME-Version: 1.0 Errors-To: pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Pdbg" This reverts commit 60d0ab1a23ae02bc4ea361899731d8b710920c99. This is fixed by: ca56cd36d6 main: Init list of procs/cores/threads Also causes problem when implementing -l option (future patch which address Linux CPUs) as [plc]_count won't be set and will result in us returning early. Signed-off-by: Michael Neuling --- src/main.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/main.c b/src/main.c index 7969833756..2b348208fb 100644 --- a/src/main.c +++ b/src/main.c @@ -382,27 +382,18 @@ static bool parse_options(int argc, char *argv[]) return false; } - if (p_count == 0) - return true; - for (i = 0; i < MAX_PROCESSORS; i++) { if (p_list[i] == 0) continue; processorsel[i] = &chipsel[i][0]; - if (c_count == 0) - continue; - for (j = 0; j < MAX_CHIPS; j++) { if (c_list[j] == 0) continue; chipsel[i][j] = &threadsel[i][j][0]; - if (t_count == 0) - continue; - for (k = 0; k < MAX_THREADS; k++) { if (t_list[k] == 0) continue;