| Message ID | 20180713062106.31114-1-mikey@neuling.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] Revert "main: Select only the targets specified on cmdline" | expand |
CCing Amitay since it's his patch I'm reverting here. Mikey On Fri, 2018-07-13 at 16:21 +1000, Michael Neuling wrote: > This reverts commit 60d0ab1a23ae02bc4ea361899731d8b710920c99. > > This is fixed by: > ca56cd36d6 main: Init list of procs/cores/threads > > Also causes problem when implementing -l option (future patch which > address Linux CPUs) as [plc]_count won't be set and will result in us > returning early. > > Signed-off-by: Michael Neuling <mikey@neuling.org> > --- > src/main.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/src/main.c b/src/main.c > index 7969833756..2b348208fb 100644 > --- a/src/main.c > +++ b/src/main.c > @@ -382,27 +382,18 @@ static bool parse_options(int argc, char *argv[]) > return false; > } > > - if (p_count == 0) > - return true; > - > for (i = 0; i < MAX_PROCESSORS; i++) { > if (p_list[i] == 0) > continue; > > processorsel[i] = &chipsel[i][0]; > > - if (c_count == 0) > - continue; > - > for (j = 0; j < MAX_CHIPS; j++) { > if (c_list[j] == 0) > continue; > > chipsel[i][j] = &threadsel[i][j][0]; > > - if (t_count == 0) > - continue; > - > for (k = 0; k < MAX_THREADS; k++) { > if (t_list[k] == 0) > continue;
diff --git a/src/main.c b/src/main.c index 7969833756..2b348208fb 100644 --- a/src/main.c +++ b/src/main.c @@ -382,27 +382,18 @@ static bool parse_options(int argc, char *argv[]) return false; } - if (p_count == 0) - return true; - for (i = 0; i < MAX_PROCESSORS; i++) { if (p_list[i] == 0) continue; processorsel[i] = &chipsel[i][0]; - if (c_count == 0) - continue; - for (j = 0; j < MAX_CHIPS; j++) { if (c_list[j] == 0) continue; chipsel[i][j] = &threadsel[i][j][0]; - if (t_count == 0) - continue; - for (k = 0; k < MAX_THREADS; k++) { if (t_list[k] == 0) continue;
This reverts commit 60d0ab1a23ae02bc4ea361899731d8b710920c99. This is fixed by: ca56cd36d6 main: Init list of procs/cores/threads Also causes problem when implementing -l option (future patch which address Linux CPUs) as [plc]_count won't be set and will result in us returning early. Signed-off-by: Michael Neuling <mikey@neuling.org> --- src/main.c | 9 --------- 1 file changed, 9 deletions(-)