diff mbox series

[8/8] pdbg: Make return codes consistent for get/put registers

Message ID 20180622045116.12059-9-rashmica.g@gmail.com
State Superseded
Headers show
Series Pre gdbserver additions | expand

Commit Message

Rashmica Gupta June 22, 2018, 4:51 a.m. UTC
---
 src/reg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Neuling June 22, 2018, 6:56 a.m. UTC | #1
This is missing a signed-off-by.


On Fri, 2018-06-22 at 14:51 +1000, Rashmica Gupta wrote:
> ---
>  src/reg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/reg.c b/src/reg.c
> index 60705f1..679bf45 100644
> --- a/src/reg.c
> +++ b/src/reg.c
> @@ -104,7 +104,7 @@ static int getprocreg(struct pdbg_target *target, uint32_t
> index, uint64_t *reg,
>  
>  	print_proc_reg(target, *reg, value, rc);
>  
> -	return !rc;
> +	return rc;
>  }
>  
>  static int getgpr(int gpr)
> -- 
> 2.14.4
>
diff mbox series

Patch

diff --git a/src/reg.c b/src/reg.c
index 60705f1..679bf45 100644
--- a/src/reg.c
+++ b/src/reg.c
@@ -104,7 +104,7 @@  static int getprocreg(struct pdbg_target *target, uint32_t index, uint64_t *reg,
 
 	print_proc_reg(target, *reg, value, rc);
 
-	return !rc;
+	return rc;
 }
 
 static int getgpr(int gpr)