From patchwork Thu May 31 05:29:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rashmica Gupta X-Patchwork-Id: 923191 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40xGHk3gClz9s08 for ; Thu, 31 May 2018 15:29:54 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Z1H9XEqo"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 40xGHk1g6HzDrbk for ; Thu, 31 May 2018 15:29:54 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Z1H9XEqo"; dkim-atps=neutral X-Original-To: pdbg@lists.ozlabs.org Delivered-To: pdbg@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c01::22f; helo=mail-pl0-x22f.google.com; envelope-from=rashmica.g@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Z1H9XEqo"; dkim-atps=neutral Received: from mail-pl0-x22f.google.com (mail-pl0-x22f.google.com [IPv6:2607:f8b0:400e:c01::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40xGHc31zBzDrbm for ; Thu, 31 May 2018 15:29:48 +1000 (AEST) Received: by mail-pl0-x22f.google.com with SMTP id az12-v6so12514276plb.8 for ; Wed, 30 May 2018 22:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cJ6RdNSfaBgtSx8uaxSqXpSBpPcd9yQPSida3AQpu1A=; b=Z1H9XEqoNSeeyqdZuV6cQqJdboYnPY+XodJ8y/BsVq6D16CUIXZu9VNdy225CECpn+ lL7zRO8N44gOg/2nLTEwc/OZgFSNt1KQ5dF90NN14ex1hf1m3dC+UMBNtJB8CMhW6imw 92mSiaYVw0mffh5xOx/B2je+jq5IbJ9SjXWI8ISVXCCrWT2oeFciYiwiXqhR98LMGDiG uTQ3JzC34eVlSO+tIMd9ZnbX5BXiFdL5rZFyjO2IhiEANaxnacN+GTR0XKGDHgmMYtp5 Oi5EWGsf84fL376NmsWeDScM4mWWx1ShUZrxV4rKwuIe7tGfOXt67OkWjG2CjPHi1Q8D I/yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cJ6RdNSfaBgtSx8uaxSqXpSBpPcd9yQPSida3AQpu1A=; b=ObqisuMIgfaRyZrbPKSBdcmXcpXj2z3dFNmsX0C+mp3UQNb7lEgNSAgukAlXYl6dI6 2BgLT5dS015kLWhyWIDX7EtmpjVEr/UsecZCeIrQNJJDUMEfds+0c7HbsVgZE1eCawLw xdXvhjOWVETOLXcQPAfnamoov5+/6H7wI/pjsLzXa7i7wvHuzBFtJKOBuErs2kHEXD4x nxyLFCR28k7BEj2G+qrAzyIcIyuGiKZqqY1xYOBquxZAXGbFx9XHK2WehdDlrxWlR+aV 7FK9a5y7qfHlhzmCT9wp6f3eHVHBbVbhOctfx0MCelKUSkSxOfBV+2YqxMzWwwnoy/F+ 1eBg== X-Gm-Message-State: ALKqPwfnaLbU70xZ2CxvbBpotGW3lD0XoQjocoZcGpkbV2i5I5vBqipv ysjd9F1BxTSZjMR7yGMbNSLy3w== X-Google-Smtp-Source: ADUXVKKr+1TLlyaM30rZaVyODPE3cT+RBdwWOTqwU9uu0nITCMWjNQPTAK/Ht5M+TzM5eCCzXJlZNw== X-Received: by 2002:a17:902:9304:: with SMTP id bc4-v6mr5600780plb.189.1527744586129; Wed, 30 May 2018 22:29:46 -0700 (PDT) Received: from rashmica.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id h10-v6sm4500515pgc.28.2018.05.30.22.29.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 May 2018 22:29:45 -0700 (PDT) From: Rashmica Gupta To: pdbg@lists.ozlabs.org Date: Thu, 31 May 2018 15:29:10 +1000 Message-Id: <20180531052915.31171-5-rashmica.g@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180531052915.31171-1-rashmica.g@gmail.com> References: <20180531052915.31171-1-rashmica.g@gmail.com> Subject: [Pdbg] [PATCH 05/10] pdbg: Tidy up putnia/putmsr X-BeenThere: pdbg@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "mailing list for https://github.com/open-power/pdbg development" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: pdbg-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Pdbg" The number of arguments required for these functions is wrong - it requires 2 arguments for putnia and putmsr, and the second one is written. The code has obviously been copy/pasted from getgpr/getspr functions where you need to supply which register and then the data. Signed-off-by: Rashmica Gupta --- src/reg.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/reg.c b/src/reg.c index 416236b..e252ab8 100644 --- a/src/reg.c +++ b/src/reg.c @@ -152,13 +152,13 @@ int handle_nia(int optind, int argc, char *argv[]) if (strcmp(argv[optind], "putnia") == 0) { uint64_t data; - if (optind + 2 >= argc) { + if (optind + 1 >= argc) { printf("%s: command '%s' requires data\n", argv[0], argv[optind]); return -1; } errno = 0; - data = strtoull(argv[optind + 2], &endptr, 0); + data = strtoull(argv[optind + 1], &endptr, 0); if (errno || *endptr != '\0') { printf("%s: command '%s' couldn't parse data '%s'\n", argv[0], argv[optind], argv[optind + 1]); @@ -221,13 +221,13 @@ int handle_msr(int optind, int argc, char *argv[]) if (strcmp(argv[optind], "putmsr") == 0) { uint64_t data; - if (optind + 2 >= argc) { + if (optind + 1 >= argc) { printf("%s: command '%s' requires data\n", argv[0], argv[optind]); return -1; } errno = 0; - data = strtoull(argv[optind + 2], &endptr, 0); + data = strtoull(argv[optind + 1], &endptr, 0); if (errno || *endptr != '\0') { printf("%s: command '%s' couldn't parse data '%s'\n", argv[0], argv[optind], argv[optind + 1]);