mbox series

[v3,0/3] Overhaul target selection

Message ID 20180604090721.18744-1-amitay@ozlabs.org
Headers show
Series Overhaul target selection | expand

Message

Amitay Isaacs June 4, 2018, 9:07 a.m. UTC 
Re-implement parse_list() to return flags rather than indices.
This avoids potential overflows and the need to do any sorting and
unique ids identification.

Changes from v2 to v3:
  - In parse_list:
   - better error reporting for invalid input
   - handle values in hex and other bases (as supported by strtoul)
  - Fix the usage message (max values are *_MAX-1)

Amitay Isaacs (3):
  main: Overhaul target selection
  main: Print specific errors for invalid arguments
  main: Print specific errors for invalid commands

 src/main.c | 198 +++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 154 insertions(+), 44 deletions(-)

Comments

Alistair Popple June 15, 2018, 4:37 a.m. UTC | #1 
Thanks Amitay, I couldn't find any more weird segfaults here so I merged it :-)

On Monday, 4 June 2018 7:07:18 PM AEST Amitay Isaacs wrote:
> Re-implement parse_list() to return flags rather than indices.
> This avoids potential overflows and the need to do any sorting and
> unique ids identification.
> 
> Changes from v2 to v3:
>   - In parse_list:
>    - better error reporting for invalid input
>    - handle values in hex and other bases (as supported by strtoul)
>   - Fix the usage message (max values are *_MAX-1)
> 
> Amitay Isaacs (3):
>   main: Overhaul target selection
>   main: Print specific errors for invalid arguments
>   main: Print specific errors for invalid commands
> 
>  src/main.c | 198 +++++++++++++++++++++++++++++++++++++++++------------
>  1 file changed, 154 insertions(+), 44 deletions(-)
> 
>