mbox series

[0/6] Overhaul target selection

Message ID 20180525045240.24196-1-amitay@ozlabs.org
Headers show
Series Overhaul target selection | expand

Message

Amitay Isaacs May 25, 2018, 4:52 a.m. UTC 
Re-implement parse_list() to return flags rather than indices.
This avoids potential overflows and the need to do any sorting and
unique ids identification.

For testing add core and thread targets in the fake backend and also in
the fake device tree.  This should help to test by hand till I figure
out how to add tests.

Also, fix dtc warnings missed by not cleaning p9-fsi.dtsi.  Thanks Joel.

Amitay Isaacs (6):
  main: Overhaul target selection
  main: Print specific errors for invalid arguments
  main: Print specific errors for invalid commands
  fake.dts: Add more targets for testing
  fake: Add fake targets for testing
  dts: Fix more warnings from dtc

 fake.dts.m4    | 121 ++++++++++++++++++++++++++++-----
 libpdbg/fake.c |  18 +++++
 p8-fsi.dts.m4  |   4 +-
 p8-i2c.dts.m4  |   2 +
 p9-fsi.dtsi.m4 |   6 ++
 src/main.c     | 179 ++++++++++++++++++++++++++++++++++++-------------
 6 files changed, 266 insertions(+), 64 deletions(-)

Comments

Joel Stanley May 25, 2018, 5:24 a.m. UTC | #1 
On 25 May 2018 at 14:22, Amitay Isaacs <amitay@ozlabs.org> wrote:
> Re-implement parse_list() to return flags rather than indices.
> This avoids potential overflows and the need to do any sorting and
> unique ids identification.
>
> For testing add core and thread targets in the fake backend and also in
> the fake device tree.  This should help to test by hand till I figure
> out how to add tests.
>
> Also, fix dtc warnings missed by not cleaning p9-fsi.dtsi.  Thanks Joel.

Nice one! I gave this a spin and can confirm that it builds cleanly.

Cheers,

Joel

>
> Amitay Isaacs (6):
>   main: Overhaul target selection
>   main: Print specific errors for invalid arguments
>   main: Print specific errors for invalid commands
>   fake.dts: Add more targets for testing
>   fake: Add fake targets for testing
>   dts: Fix more warnings from dtc
>
>  fake.dts.m4    | 121 ++++++++++++++++++++++++++++-----
>  libpdbg/fake.c |  18 +++++
>  p8-fsi.dts.m4  |   4 +-
>  p8-i2c.dts.m4  |   2 +
>  p9-fsi.dtsi.m4 |   6 ++
>  src/main.c     | 179 ++++++++++++++++++++++++++++++++++++-------------
>  6 files changed, 266 insertions(+), 64 deletions(-)
>
> --
> 2.17.0
>
> --
> Pdbg mailing list
> Pdbg@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/pdbg