| Message ID | 1442934550-25385-1-git-send-email-damien.lespiau@intel.com |
|---|---|
| State | Accepted |
| Headers | show |
> Right now flake will inspect everything in the root directory. We can > avoid a bit of work, telling it to only look at the patchwork/ > directory. > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> Do you think we should be scanning 'tests' also? Enhancing the readability of tests is undoubtedly a good thing. Stephen
On Tue, Sep 22, 2015 at 04:42:09PM +0100, Finucane, Stephen wrote: > > Right now flake will inspect everything in the root directory. We can > > avoid a bit of work, telling it to only look at the patchwork/ > > directory. > > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > Do you think we should be scanning 'tests' also? Enhancing the > readability of tests is undoubtedly a good thing. I did wonder about that and was thinking it should descend in tests/ as well indeed.
> On Tue, Sep 22, 2015 at 04:42:09PM +0100, Finucane, Stephen wrote: > > > Right now flake will inspect everything in the root directory. We can > > > avoid a bit of work, telling it to only look at the patchwork/ > > > directory. > > > > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > > > Do you think we should be scanning 'tests' also? Enhancing the > > readability of tests is undoubtedly a good thing. > > I did wonder about that and was thinking it should descend in tests/ as > well indeed. Ah I thought 'tests' was a sibling to 'patchwork', not a child. My mistake! Acked-by: Stephen Finucane <stephen.finucane@intel.com>
On Tue, Sep 22, 2015 at 06:09:08PM +0100, Finucane, Stephen wrote: > > On Tue, Sep 22, 2015 at 04:42:09PM +0100, Finucane, Stephen wrote: > > > > Right now flake will inspect everything in the root directory. We can > > > > avoid a bit of work, telling it to only look at the patchwork/ > > > > directory. > > > > > > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > > > > > Do you think we should be scanning 'tests' also? Enhancing the > > > readability of tests is undoubtedly a good thing. > > > > I did wonder about that and was thinking it should descend in tests/ as > > well indeed. > > Ah I thought 'tests' was a sibling to 'patchwork', not a child. My mistake! > > Acked-by: Stephen Finucane <stephen.finucane@intel.com> Picked up for the next pull request. Thanks for the review!
> On Tue, Sep 22, 2015 at 06:09:08PM +0100, Finucane, Stephen wrote: > > > On Tue, Sep 22, 2015 at 04:42:09PM +0100, Finucane, Stephen wrote: > > > > > Right now flake will inspect everything in the root directory. We > can > > > > > avoid a bit of work, telling it to only look at the patchwork/ > > > > > directory. > > > > > > > > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > > > > > > > Do you think we should be scanning 'tests' also? Enhancing the > > > > readability of tests is undoubtedly a good thing. > > > > > > I did wonder about that and was thinking it should descend in tests/ as > > > well indeed. > > > > Ah I thought 'tests' was a sibling to 'patchwork', not a child. My > mistake! > > > > Acked-by: Stephen Finucane <stephen.finucane@intel.com> > > Picked up for the next pull request. Thanks for the review! > > -- > Damien Merged.
diff --git a/tox.ini b/tox.ini index 891fc5e..3b59ddb 100644 --- a/tox.ini +++ b/tox.ini @@ -22,7 +22,7 @@ passenv = [testenv:pep8] basepython = python2.7 deps = flake -commands = flake8 {posargs} +commands = flake8 {posargs} patchwork [flake8] ignore = E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405
Right now flake will inspect everything in the root directory. We can avoid a bit of work, telling it to only look at the patchwork/ directory. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- tox.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)