diff mbox

[42/51] patch: Move the submitter and date out of the details

Message ID 1440440620-25937-43-git-send-email-damien.lespiau@intel.com
State Changes Requested
Headers show

Commit Message

Damien Lespiau Aug. 24, 2015, 6:23 p.m. UTC 
From: Belén Barros Peña <belen.barros.pena@intel.com>

Trying to reduce the number of read-only fields in details.

Signed-off-by: Belén Barros Peña <belen.barros.pena@intel.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
---
 patchwork/templates/patchwork/patch.html | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

Comments

Stephen Finucane Sept. 10, 2015, 4:28 p.m. UTC | #1 
> From: Belén Barros Peña <belen.barros.pena@intel.com>

> 

> Trying to reduce the number of read-only fields in details.

> 

> Signed-off-by: Belén Barros Peña <belen.barros.pena@intel.com>

> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>


The author field needs significantly more contrast against the surrounding text (bold and black with surrounding text non-bold and lighter grey, perhaps?). GitHub do this well IMO:

  https://github.com/naoyukik/CTags/commit/756bcbe63234a559bd0ee66690811589ea88929d
diff mbox

Patch

diff --git a/patchwork/templates/patchwork/patch.html b/patchwork/templates/patchwork/patch.html
index 0322abf..861a157 100644
--- a/patchwork/templates/patchwork/patch.html
+++ b/patchwork/templates/patchwork/patch.html
@@ -32,16 +32,15 @@  function toggle_headers(link_id, headers_id)
 }
 </script>
 
+<h2>{{ patch.name }}</h2>
+<div class="core-info">
+    <span>Submitted by {{ patch.submitter|personify:project }} on {{ patch.date }}</span>
+</div>
+
+<h2>Details</h2>
+
 <table class="patchmeta">
  <tr>
-  <th>Submitter</th>
-  <td>{{ patch.submitter|personify:project }}</td>
- </tr>
- <tr>
-  <th>Date</th>
-  <td>{{ patch.date }}</td>
- </tr>
- <tr>
   <th>Message ID</th>
   <td>{{ patch.msgid }}</td>
  </tr>