| Message ID | 1440440620-25937-24-git-send-email-damien.lespiau@intel.com |
|---|---|
| State | Changes Requested |
| Headers | show |
> The only tricky thing is the inclusion of the EcmaScript shim for IE8. > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> This is an alternative to the jQuery UI option I took for the delegate autocomplete work. However, I don't mind which one is chosen. Acked-by: Stephen Finucane <stephen.finucane@intel.com>
> The only tricky thing is the inclusion of the EcmaScript shim for IE8. > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> Combine this with patch 21. They're too closely related to separate IMO.
> > The only tricky thing is the inclusion of the EcmaScript shim for IE8. > > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > Combine this with patch 21. They're too closely related to separate IMO. And what happened to patch 22?
On Wed, Sep 09, 2015 at 04:06:49PM +0100, Finucane, Stephen wrote: > > > The only tricky thing is the inclusion of the EcmaScript shim for IE8. > > > > > > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> > > > > Combine this with patch 21. They're too closely related to separate IMO. > > And what happened to patch 22? mailing-lists suck. point proven :) The patch did go out but I'm guessing mailman scrapped it, maybe because it was too big.
diff --git a/templates/base.html b/templates/base.html index cef0671..8d9ff75 100644 --- a/templates/base.html +++ b/templates/base.html @@ -7,6 +7,7 @@ <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> <title>{% block title %}Patchwork{% endblock %} - Patchwork</title> <link rel="stylesheet" type="text/css" href="{% static "css/bootstrap.min.css" %}"/> + <link rel="stylesheet" type="text/css" href="{% static "css/selectize.bootstrap3.css" %}"/> <link rel="stylesheet" type="text/css" href="{% static "css/style.css" %}"/> <script type="text/javascript" src="{% static "js/common.js" %}"></script> <script type="text/javascript" src="{% static "js/jquery-1.10.1.min.js" %}"></script> @@ -16,8 +17,10 @@ <script src="https://oss.maxcdn.com/html5shiv/3.7.2/html5shiv.min.js"> </script> <script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script> + <script src="http://cdnjs.cloudflare.com/ajax/libs/es5-shim/2.0.8/es5-shim.min.js"></script> <![endif]--> <script type="text/javascript" src="{% static "js/bootstrap.min.js" %}"></script> + <script type="text/javascript" src="{% static "js/selectize.min.js" %}"></script> {% block headers %}{% endblock %} </head> <body>
The only tricky thing is the inclusion of the EcmaScript shim for IE8. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> --- templates/base.html | 3 +++ 1 file changed, 3 insertions(+)